Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes in progammatic example #118

Merged
merged 1 commit into from
Mar 25, 2021
Merged

Fixes in progammatic example #118

merged 1 commit into from
Mar 25, 2021

Conversation

samirsilwal
Copy link
Collaborator

Changes

@samirsilwal samirsilwal self-assigned this Mar 24, 2021
@cham11ng cham11ng merged commit 1d3a739 into master Mar 25, 2021
@cham11ng cham11ng deleted the examples branch March 25, 2021 04:53
mesaugat
mesaugat reviewed Mar 25, 2021
View reviewed changes
examples/node-mssql-programmatic-use/connections.sync-db.json.example
"port": 1433,
"user": "sa",
"database": "tempdb",
"password": "Password@123"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samirsilwal You did the same thing here. Please set is as Secret@123. Copy pasting this example file should work out of the box. 🙏

@mesaugat mesaugat mentioned this pull request Mar 25, 2021
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mesaugat mesaugat mesaugat left review comments

@cham11ng cham11ng cham11ng approved these changes

@aanchal-adk aanchal-adk Awaiting requested review from aanchal-adk

Assignees

@samirsilwal samirsilwal

Labels
example
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samirsilwal @mesaugat @cham11ng