Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to provide custom configuration with --config flag #120

Merged
merged 5 commits into from
Mar 27, 2021
Merged

Ability to provide custom configuration with --config flag #120

merged 5 commits into from
Mar 27, 2021

Conversation

samirsilwal
Copy link
Collaborator

Changes

  • Added --config flag in each command to provide custom config source for each command run
    Screenshot from 2021-03-26 14-21-27
    Screenshot from 2021-03-26 14-21-50
    Screenshot from 2021-03-26 14-22-32
    Screenshot from 2021-03-26 14-22-52

@samirsilwal samirsilwal self-assigned this Mar 26, 2021
cham11ng
cham11ng reviewed Mar 26, 2021
View reviewed changes
src/config.ts Outdated Show resolved Hide resolved
cham11ng
cham11ng reviewed Mar 26, 2021
View reviewed changes
src/config.ts Outdated Show resolved Hide resolved
mesaugat
mesaugat reviewed Mar 26, 2021
View reviewed changes
package.json Outdated Show resolved Hide resolved
@samirsilwal samirsilwal force-pushed the sync-db-custom-config branch from f9e8294 to 3852895 Compare March 26, 2021 13:20
mesaugat
mesaugat reviewed Mar 27, 2021
View reviewed changes
src/config.ts Outdated Show resolved Hide resolved
@samirsilwal samirsilwal requested a review from mesaugat March 27, 2021 15:43
mesaugat
mesaugat approved these changes Mar 27, 2021
View reviewed changes
Copy link
Member

@mesaugat mesaugat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@mesaugat mesaugat force-pushed the sync-db-custom-config branch from 2d6b973 to 14a3044 Compare March 27, 2021 18:17
@mesaugat mesaugat merged commit a3a8346 into master Mar 27, 2021
@mesaugat mesaugat deleted the sync-db-custom-config branch March 27, 2021 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanchal-adk aanchal-adk aanchal-adk approved these changes

@mesaugat mesaugat mesaugat approved these changes

@kabirbaidhya kabirbaidhya Awaiting requested review from kabirbaidhya

@cham11ng cham11ng Awaiting requested review from cham11ng

Assignees

@samirsilwal samirsilwal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@samirsilwal @mesaugat @cham11ng @aanchal-adk