Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant existDir check #134

Merged
merged 1 commit into from
Sep 10, 2021
Merged

Remove redundant existDir check #134

merged 1 commit into from
Sep 10, 2021

Conversation

samirsilwal
Copy link
Collaborator

Change

  • The condition for prepare in synchonize api for loading migration wouldn't work correctly if skip-migration is set when dir exists

Fix

  • Remove redundant addition of dirExists check

@samirsilwal samirsilwal self-assigned this Sep 10, 2021
@samirsilwal samirsilwal merged commit 566c194 into master Sep 10, 2021
@samirsilwal samirsilwal deleted the quick-fix branch September 10, 2021 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Soneshaps Soneshaps Soneshaps approved these changes

@aanchal-adk aanchal-adk aanchal-adk approved these changes

@cham11ng cham11ng cham11ng approved these changes

Assignees

@samirsilwal samirsilwal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@samirsilwal @cham11ng @aanchal-adk @Soneshaps