Use knex to create, run, rollback migrations with samples #24
Conversation
Codecov Report
@@ Coverage Diff @@
## master #24 +/- ##
=======================================
Coverage 21.02% 21.02%
=======================================
Files 11 11
Lines 176 176
Branches 11 11
=======================================
Hits 37 37
Misses 137 137
Partials 2 2Continue to review full report at Codecov.
|
|
@p0k8h Please add a description of what you did in the description section as well. Example: #7 |
|
We usually use imperative mood "spoken or written as if giving a command or instruction" for commits. The commit should explain what the change is. Read here: https://chris.beams.io/posts/git-commit/ |
mesaugat
changed the title
|
@p0k8h Let's convert all the files added to JavaScript from TS because it looks like the example project was originally based in JS. This is my bad during briefing 😄.
|
|
@p0k8h Also update the PR title and description. |
parwatcodes
changed the title
mesaugat
changed the title
| * @returns {Promise<any>} | ||
| * | ||
| */ | ||
|
|
There was a problem hiding this comment.
Remove this new line here. Doc blocks should be attached to the method.
| * | ||
| * @param {Knex} knex | ||
| * @returns {Promise<any>} | ||
| * |
| * @returns {Promise<any>} | ||
| * | ||
| */ | ||
|
|
| * | ||
| * @param {Knex} knex | ||
| * @returns {Promise<any>} | ||
| * |
| * | ||
| * @param {Knex} knex | ||
| * @returns {Promise<any>} | ||
| * |
| * @returns {Promise<any>} | ||
| * | ||
| */ | ||
|
|
| * @param {Knex} knex | ||
| * @returns {Promise<any>} | ||
| */ | ||
|
|
parwatcodes
force-pushed
the
sample-tables-using-knex-migrations
branch
from
7062df4 to
077975c
Compare
parwatcodes
force-pushed
the
sample-tables-using-knex-migrations
branch
from
077975c to
fd9cc81
Compare
examples/node-app-mssql/src/migrations/20191124213750_create_user_table.js
Show resolved
Hide resolved
| * @param {Knex} knex | ||
| * @returns {Promise<any>} | ||
| */ | ||
| exports.up = function(knex) { |
There was a problem hiding this comment.
Can we do export function syntax instead?
There was a problem hiding this comment.
Perhaps you'll need a stub file for this. cc @mesaugat
There was a problem hiding this comment.
Can we do
export functionsyntax instead?
To use es6 syntax we need a transpiler(babel). Shall I add a babel config.
| * @param {Knex} knex | ||
| * @returns {Promise<any>} | ||
| */ | ||
| exports.down = function(knex) { |
There was a problem hiding this comment.
same here and all over.
| * @param {Knex} knex | ||
| * @returns {Promise<any>} | ||
| */ | ||
| exports.up = function(knex) { |
| * @param {Knex} knex | ||
| * @returns {Promise<any>} | ||
| */ | ||
| exports.down = function(knex) { |
examples/node-app-mssql/package.json
Outdated
| "@babel/node": "^7.7.4", | ||
| "@babel/preset-env": "^7.7.4", | ||
| "@babel/register": "^7.7.4", | ||
| "babel-core": "^6.26.3", |
There was a problem hiding this comment.
Remove this. You already have included @babel/core.
Resolves #21
knexfile.jsin root is the config file for knex./src/migrations/contains 2 migration files forusersandtaskstable.package.jsoncontains 3 new scripts.make: to create migration files.migrate: to run the migration.rollback: to rollback migration.