Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle the invalid command resulting in infinite loop #243

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

samirsilwal
Copy link
Collaborator

Changes

  • Check if the command provided to sync-db in valid one

  • Show the available command in case of invalid entry

  • Fixes the infinite loop while unknown command is given to sync-db

Test

Before

DEBUG=* yarn sync-db gg
image

After

DEBUG=* yarn sync-db gg

image

@samirsilwal samirsilwal self-assigned this Oct 26, 2024
@samirsilwal
Copy link
Collaborator Author

Resolves #242

@samirsilwal samirsilwal added bug Something isn't working bugfix and removed bug Something isn't working labels Oct 26, 2024
Copy link

codecov bot commented Oct 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 35.13%. Comparing base (8322436) to head (c9a1cfb).

Files with missing lines Patch % Lines
src/commands/index.ts 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #243      +/-   ##
==========================================
- Coverage   35.34%   35.13%   -0.21%     
==========================================
  Files          33       34       +1     
  Lines         863      868       +5     
  Branches      115      116       +1     
==========================================
  Hits          305      305              
- Misses        549      554       +5     
  Partials        9        9              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samirsilwal
Copy link
Collaborator Author

Will add the tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant