Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump knex to version 0.20.4 and upgrade vulnerable packages #34

Merged
merged 3 commits into from
Dec 18, 2019

Conversation

mesaugat
Copy link
Member

@mesaugat mesaugat commented Dec 18, 2019

  • Use PromiseLike type to comply with knex return types which is incompatible with native Promise type
  • Upgrade package: codecov
  • Upgrade sub dependencies that were reported as vulnerable

@mesaugat mesaugat added the dependencies Pull requests that update a dependency file label Dec 18, 2019
@codecov-io
Copy link

codecov-io commented Dec 18, 2019

Codecov Report

Merging #34 into master will not change coverage.
The diff coverage is 50%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #34   +/-   ##
======================================
  Coverage    22.9%   22.9%           
======================================
  Files          11      11           
  Lines         179     179           
  Branches       11      11           
======================================
  Hits           41      41           
  Misses        137     137           
  Partials        1       1
Impacted Files Coverage Δ
src/Connection.ts 0% <0%> (ø) ⬆️
src/util/promise.ts 33.33% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a477bc0...ff1de20. Read the comment docs.

@mesaugat mesaugat changed the title Upgrade vulnerable packages Bump knex to version 0.20.4 and upgrade vulnerable packages Dec 18, 2019
@mesaugat mesaugat requested a review from SafalPandey December 18, 2019 10:49
@kabirbaidhya kabirbaidhya merged commit 9647793 into master Dec 18, 2019
@kabirbaidhya kabirbaidhya deleted the upgrade-packages branch December 18, 2019 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants