Support both sequential and parallel execution strategies for running synchronization #55

kabirbaidhya · 2020-03-20T21:08:14Z

Support sequential execution strategy with a configurable option

Add a new config option execution supporting two choices sequential and parallel - default is still parallel execution so no breaking change.
Update utilities and add tests:
- Change promise.runSequentially to accept promisers instead of promises.
- Extract the execution process to services/execution.ts service.
- Add tests
This is an opt-in option for the user. If they want to run it in a sequential mode (one connection at a time), they'll need to add this to their config:
```
execution: sequential
```

Preview

sequential

parallel

codecov-io · 2020-03-21T05:53:37Z

Codecov Report

Merging #55 into master will not change coverage by %.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #55   +/-   ##
=======================================
  Coverage   38.18%   38.18%           
=======================================
  Files          19       19           
  Lines         364      364           
  Branches       32       32           
=======================================
  Hits          139      139           
  Misses        223      223           
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a93ff8...4a93ff8. Read the comment docs.

Make `promise.runSequentially` accept a list of promisers - that is an array of functions that returns promises. This allows the function to invoke the function in the future to control the execution behavior.

src/constants.ts

src/services/execution.ts

test/service/execution.test.ts

Co-Authored-By: Saugat Acharya <mesaugat@gmail.com>

kabirbaidhya changed the title ~~(WIP) Support sequential strategy for running synchronization~~ Support both sequential and parallel execution strategies for running synchronization Mar 21, 2020

kabirbaidhya marked this pull request as ready for review March 21, 2020 06:06

kabirbaidhya requested review from mesaugat, cham11ng, SafalPandey and silwalanish March 21, 2020 06:06

kabirbaidhya self-assigned this Mar 21, 2020

kabirbaidhya added config feature internals labels Mar 21, 2020

kabirbaidhya added 19 commits March 21, 2020 16:53

Update runSequentially to return values

76c69c1

Test runSequentially returns values in the order

bfe5069

Add a failing test for runSequentially

3792c6e

Make runSequentially accept array of Promiser<T>

f203ea4

Make `promise.runSequentially` accept a list of promisers - that is an array of functions that returns promises. This allows the function to invoke the function in the future to control the execution behavior.

Fix tests

d91da32

Update tests

1f05877

Add a new config option runSequentially

2e33866

Change to executionStrategy

c081a28

Add execution service to run processes

f585cdf

Execute processes based on strategy

95459a0

Add log for execution strategy

a1977a0

Update promise tests

2da8926

Move timeout() to promise.ts

2a12011

Add tests for sequential and parallel execution

85f7492

Add error catching tests as well

b5e9779

Fix the visisble logging

2ec73ce

Add getElapseTime util function

34973da

Use getElapsedTime function

97cc88f

Support fixed decimal number

8757787

kabirbaidhya added 3 commits March 21, 2020 16:53

Display the total elapsed time

027642c

Don't capture init times

f360682

Remove unnecessary code

5e060d2

kabirbaidhya force-pushed the sequential-run branch from 340a30d to 5e060d2 Compare March 21, 2020 11:08

kabirbaidhya mentioned this pull request Mar 21, 2020

Migrations support #51

Merged

kabirbaidhya commented Mar 22, 2020

View reviewed changes

src/constants.ts Outdated Show resolved Hide resolved

kabirbaidhya added 2 commits March 22, 2020 17:05

Rename executionStrategy -> execution

481028f

Use sequential execution in one example

8d5d30c