Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organize directories and minor improvements for consistency and trivial fixes #57

Merged
merged 8 commits into from
Mar 27, 2020

Conversation

kabirbaidhya
Copy link
Contributor

@kabirbaidhya kabirbaidhya commented Mar 23, 2020

Minor Fixes

  • Move SYNC_DB_CLI declaration to the beginning of the CLI execution to avoid potential confusion.
  • Fix an issue for run-dev.sh, it didn't work with user provided command line flags such as ./bin/run-dev.sh --version wouldn't work as it wouldn't pass args to the main script -- fixed.

Improvements for consistency

  • Organize directories - prefer singular directories to maintain consistency everywhere.
  • Organize test directories - there weren't any.
  • Make test labels consistent.

The tests look consistent and clean now.
image

@kabirbaidhya kabirbaidhya changed the title Organize directories and minor improvements for consistency Organize directories and minor improvements for consistency and trivial fixes Mar 23, 2020
@kabirbaidhya kabirbaidhya self-assigned this Mar 23, 2020
@kabirbaidhya kabirbaidhya requested a review from mesaugat March 23, 2020 18:13
@kabirbaidhya kabirbaidhya requested a review from cham11ng March 23, 2020 18:15
@codecov-io
Copy link

codecov-io commented Mar 23, 2020

Codecov Report

Merging #57 into master will increase coverage by 0.56%.
The diff coverage is 40.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #57      +/-   ##
==========================================
+ Coverage   38.18%   38.75%   +0.56%     
==========================================
  Files          19       19              
  Lines         364      369       +5     
  Branches       32       32              
==========================================
+ Hits          139      143       +4     
- Misses        223      224       +1     
  Partials        2        2              
Impacted Files Coverage Δ
src/SyncDb.ts 0.00% <ø> (ø)
src/api.ts 0.00% <0.00%> (ø)
src/enum/DatabaseObjectTypes.ts 100.00% <ø> (ø)
src/service/configInjection.ts 40.62% <ø> (ø)
src/service/execution.ts 100.00% <ø> (ø)
src/service/sync.ts 0.00% <0.00%> (ø)
src/config.ts 53.84% <50.00%> (+1.67%) ⬆️
src/service/sqlRunner.ts 61.36% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 942e423...98e9c3a. Read the comment docs.

@kabirbaidhya
Copy link
Contributor Author

Merging this as these are few trivial fixes and path changes / aesthetics. There is other PR which requires review and thoughts -> #58.

@kabirbaidhya kabirbaidhya merged commit 0de5df6 into master Mar 27, 2020
@kabirbaidhya kabirbaidhya deleted the consistency branch March 27, 2020 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants