Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update packages to address security vulnerabilities and deprecations #236

Merged
merged 7 commits into from
Dec 10, 2019
Merged

Update packages to address security vulnerabilities and deprecations #236

merged 7 commits into from
Dec 10, 2019

Conversation

RecursiveCptHook
Copy link
Contributor

@RecursiveCptHook RecursiveCptHook commented Dec 10, 2019 •
edited
Loading

WIP

Please feel free to call anything out in comments, thanks!

CHANGES

  • Node v12 as well as a number of updates to the package.json versions
    • Updates to old/insecure/deprecated packages
  • Performed npm audits and applied fixes where applicable
  • Address breaking change in ws v3 in re: to ws.updateReqs

This is currently passing TravisCI builds/tests and local tests on my Macbook. 👍

@RecursiveCptHook RecursiveCptHook changed the title Test updates to packages to address security vulnerabilities and deprecations Update packages to address security vulnerabilities and deprecations Dec 10, 2019
jselstad
jselstad approved these changes Dec 10, 2019
View reviewed changes
Copy link
Contributor

@jselstad jselstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes all look kosher to me; all the examples run locally (both via pure .html and live-server), so I dub this PR good!

@jselstad jselstad merged commit a3d8605 into master Dec 10, 2019
@jselstad jselstad deleted the test-updates branch December 10, 2019 21:05
@RecursiveCptHook RecursiveCptHook mentioned this pull request Apr 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jselstad jselstad jselstad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RecursiveCptHook @jselstad