[FEAT] Prune and Upgrade Dependencies; Add Github Actions #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fewer dependencies, the better for the coming es5 modules refactor...
Now to consider excising ws and gl-matrix... And then switching to es5 modules proper.
zalo
changed the title
We still have a vestigial "Tool" bool that will always be false... And couldn't get rid of Pointables because fingers are inherited from them...
zalo
requested review from
RecursiveCptHook
and removed request for
RecursiveCptHook
| @@ -0,0 +1,50 @@ | |||
| name: leapjs - Build Library and Run Unit Tests | |||
RecursiveCptHook
approved these changes
Nov 23, 2020
There was a problem hiding this comment.
Changes LGTM 😎
Thanks for putting this together, @zalo -- much appreciated! 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will remove the runtime dependencies of Leap.js and update the package to use ES5 Modules.
Additional changes and excisions will take place to bring the exposed API up-to-date, as well as the contact area with
three.js.Todo:
underscore(Use ES5 Replacements)RemoveUsed for NodeJS Connections...ws(Use Browser Websocket Implementation)RemoveThese are actually nice...gl-matrix(Write Custom Vector/Matrix functions)Refactor for ES5 ModulesOut of Scope for this PR...Toolsand(PointablesFingers inherit fromPointables)