[UPGRADE] Upgrade ws 7.4.6, bump version to 1.1.1 #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependabot is complaining about the ecstatic file server, which I believe is only used in `http-server`, which is only used in a vestigial preview command in the Makefile. Since VS Code now has `live-server` previewing extensions, I'm just removing that command. Hopefully this gets us back to a clean universe.
This allows LeapJS to be imported via `import "../node_modules/leapjs/leap-1.1.0.js";`
And used via `window.Leap` ala:
`this.controller = new window.Leap.Controller({optimizeHMD: true}).connect();`
|
Looks good to me! (Examples are all tested to be working against a live service.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates a bunch of dependencies, includes the ES6 Module patch "fix", and bumps the minor version.|
Merging this will allow us to close #245, #249, #252, and #253.