This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
Fixed location of OAuth link. Removed instance member github_username from CLI #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… from CLI, no longer needed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current OAuth link points to a depreciated site. It now points to the link https://base.flatironschool.com/account/manage which is where the key is now located. I removed the instance member github_username from the CLI class, as its only use was to interpolate their specific username into the CLI output. This is no longer needed, as the new link redirects the student to their specific page. Additionally, I removed the variable github_username from the Setup class, which was used as an argument to CLI's initialize method. Because CLI's github_username member has been removed, the init call no longer requires arguments.