This repository has been archived by the owner on Jan 10, 2023. It is now read-only.
Add emulator padding and solidify fit #473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notnotdrew
commented
May 19, 2017
| this.emulator.fit(); | ||
| // Two calls are necessary to properly fit after the font-size has changed | ||
| this.emulator.fit() | ||
| this.emulator.fit() |
There was a problem hiding this comment.
@ktravers if you're interested, this is the magic that seems to have guaranteed, finally (the last attempt actually could still break), that the emulator will fit inside its panel 🙄
I think what's happening is that the first call to emulator.fit() is pushing xterm to adjust to font-size changes we've made, and the second call is then taking that and actually fitting the emulator in its container. That's just a hunch though. Whatever it is, it works 🤷♂️
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #464
While working on this, I discovered a few more ways to break the emulator fit—so that is addressed here as well and seems to be pretty solid now.