Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md dead link to HivemindStrategy #607

Merged
merged 1 commit into from
Jul 14, 2024

Conversation

cleong110
Copy link
Contributor

Readme link to HivemindStrategy in PyTorch Lightning docs was giving 404, as PyTorch Lighting updated their docs structure, shifting the relevant page from https://lightning.ai/docs/pytorch/stable/advanced/third_party/hivemind.html to https://lightning.ai/docs/pytorch/stable/integrations/strategies/Hivemind.html. Updated the link accordingly

Copy link

codecov bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.38%. Comparing base (d20e810) to head (ffdb014).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #607      +/-   ##
==========================================
- Coverage   85.39%   85.38%   -0.02%     
==========================================
  Files          81       81              
  Lines        8006     8006              
==========================================
- Hits         6837     6836       -1     
- Misses       1169     1170       +1     

see 1 file with indirect coverage changes

Readme link to HivemindStrategy in PyTorch Lightning docs was giving 404, as PyTorch Lighting updated their docs structure, shifting the relevant page from https://lightning.ai/docs/pytorch/stable/advanced/third_party/hivemind.html to https://lightning.ai/docs/pytorch/stable/integrations/strategies/Hivemind.html. Updated the link accordingly
Copy link
Member

@mryab mryab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@mryab mryab merged commit f98acba into learning-at-home:master Jul 14, 2024
13 checks passed
mryab pushed a commit that referenced this pull request Oct 13, 2024
Readme link to HivemindStrategy in PyTorch Lightning docs was giving 404, as PyTorch Lighting updated their docs structure, shifting the relevant page from https://lightning.ai/docs/pytorch/stable/advanced/third_party/hivemind.html to https://lightning.ai/docs/pytorch/stable/integrations/strategies/Hivemind.html. Updated the link accordingly

(cherry picked from commit f98acba)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants