Improve the process cleanup logic when running tests #616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mryab
force-pushed
the
improve_process_cleanup
branch
from
e955347
to
784b7b9
Compare
justheuristic
approved these changes
Jun 9, 2024
mryab
added a commit
that referenced
this pull request
Oct 13, 2024
* Improve the process cleanup logic when running tests * Add graceful shutdown in test_dht_experts * Add graceful shutdown in test_fault_tolerance (cherry picked from commit 51e5942)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
cleanup_childrenfunction attempts to terminate all child processes, even those that have already stopped. This PR makes the cleanup more robust and avoids terminating dead processes by usingpsutil.wait_procs, which can distinguish dead and alive processes