Skip to content

Commit

Permalink
Merge pull request #463 from ShivangRawat30/459
Browse files Browse the repository at this point in the history
Warning when using `KResponsiveWindow`
  • Loading branch information
MisRob authored Oct 13, 2023
2 parents f990471 + ccb7e6c commit e578ede
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 1 deletion.
13 changes: 12 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,18 @@ Changelog is rather internal in nature. See release notes for the public overvie

<!-- All new changelog items should come here -->

## Version 2.0.0
- [#463]
- **Description:** Add deprecation warning for KResponsiveWindowMixin
- **Products impact:** updated API
- **Addresses:** https://github.com/learningequality/kolibri-design-system/issues/459
- **Components:** KResponsiveWindowMixin
- **Breaking:** no
- **Impacts a11y:** no
- **Guidance:** useKResponsiveWindow composable should be used instead

[#463]: https://github.com/learningequality/kolibri-design-system/pull/463

## Version 2.0.0-beta0 (released - do not add new items)

- [#462]
- **Description:** Fix internal links in design system documentation
Expand Down
2 changes: 2 additions & 0 deletions lib/KResponsiveWindowMixin.js
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,8 @@ export default {
},
},
mounted() {
// prettier-ignore
console.warn(`Please use 'useKResponsiveWindow' composable instead of 'KResponsiveWindow' mixin`);
addWindowListener(this._updateWindow);
},
beforeDestroy() {
Expand Down

0 comments on commit e578ede

Please sign in to comment.