Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added test cases for create new facility feature #11303

Merged
merged 2 commits into from
Sep 29, 2023
Merged

added test cases for create new facility feature #11303

merged 2 commits into from
Sep 29, 2023

Conversation

Jaspreet-singh-1032
Copy link
Contributor

Summary

Follow up for #11197

Added python testcases for create new facility feature API.

…

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@github-actions github-actions bot added DEV: backend Python, databases, networking, filesystem... SIZE: small labels Sep 26, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 26, 2023 •
edited
Loading

Build Artifacts

Asset type Download link
PEX file kolibri-0.16.0b5.dev0_git.321.gc79d0da1.pex
Windows Installer (EXE) kolibri-0.16.0b5.dev0+git.321.gc79d0da1-unsigned.exe
Debian Package kolibri_0.16.0b5.dev0+git.321.gc79d0da1-0ubuntu1_all.deb
Mac Installer (DMG) kolibri-0.16.0b5.dev0+git.321.gc79d0da1-0.3.0.dmg
Android Package (APK) kolibri-0.16.0b5.dev0+git.321.gc79d0da1-0.1.0-debug.apk
TAR file kolibri-0.16.0b5.dev0+git.321.gc79d0da1.tar.gz
WHL file kolibri-0.16.0b5.dev0+git.321.gc79d0da1-py2.py3-none-any.whl

@MisRob MisRob added the TODO: needs review Waiting for review label Sep 28, 2023
@MisRob MisRob requested review from rtibbles and akolson September 28, 2023 10:36
rtibbles
rtibbles approved these changes Sep 29, 2023
View reviewed changes
Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent - you can also use the TestCase assert methods, for future reference: https://docs.python.org/3/library/unittest.html#assert-methods

And the extra Django TestCase assertion methods too:
https://docs.djangoproject.com/en/1.11/topics/testing/tools/#assertions

@rtibbles
Copy link
Member

Thanks for this follow up @Jaspreet-singh-1032 - very nice to see.

@rtibbles rtibbles merged commit 16e94a3 into learningequality:develop Sep 29, 2023
34 checks passed
@Jaspreet-singh-1032
Copy link
Contributor Author

Thanks @rtibbles for these suggestions. I will definitely consider them for future contributions :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rtibbles rtibbles rtibbles approved these changes

@akolson akolson Awaiting requested review from akolson

Assignees
No one assigned
Labels
DEV: backend Python, databases, networking, filesystem... SIZE: small TODO: needs review Waiting for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jaspreet-singh-1032 @rtibbles @MisRob