-
Notifications
You must be signed in to change notification settings - Fork 637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fork ui-menu and make active items clickable #1162
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1162 +/- ##
========================================
Coverage 73.79% 73.79%
========================================
Files 136 136
Lines 4358 4358
Branches 491 491
========================================
Hits 3216 3216
Misses 1080 1080
Partials 62 62 Continue to review full report at Codecov.
|
@christianmemije @rtibbles thoughts? |
font-weight: bold | ||
opacity: 1 | ||
.ui-menu-option__text |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Would be helpful if the options were links. |
Did you make any changes besides adding the 'active' option? If so can you point them out? |
Agreed. There's a lot of cleanup and modification we can do now with the code in our own repo.
Nope. This PR is broken into two main commits: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works, can do further clean up as we turn these things into links!
Copies code from ui-menu into our code-base, and adds a new 'active' option.
Shorter-term, this provides a way to get back to the root level of the coach app after selecting a class, which is not currently possible with the state of the UI.
Longer-term, this also allows us greater control over this component and allows us to remove some unscoped files.
fixes #1160