Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update now value in SyncStatusDisplay #12110

Merged
merged 1 commit into from
May 7, 2024
Merged

Update now value in SyncStatusDisplay #12110

merged 1 commit into from
May 7, 2024

Conversation

AlexVelezLl
Copy link
Member

Summary

Update now value in SyncStatusDisplay component.

Compartir.pantalla.-.2024-04-26.11_36_22.mp4

References

Closes #11880.

Reviewer guidance

  1. Set up two Kolibris - one as a Learn Only Device (LOD) and one as a full facility. The LOD should be set up to sync back the main facility
  2. Assign some resources to the Learner
  3. Observe the accuracy of sync status and the calculation of relative time
  4. Repeat if necessary

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@github-actions GitHub Actions
Copy link
Contributor

Build Artifacts

Asset type Download link
PEX file kolibri-0.16.1a0.dev0_git.80.g262e4a93.pex
Windows Installer (EXE) kolibri-0.16.1a0.dev0+git.80.g262e4a93-windows-setup-unsigned.exe
Debian Package kolibri_0.16.1a0.dev0+git.80.g262e4a93-0ubuntu1_all.deb
Android Package (APK) kolibri-0.16.1a0.dev0+git.80.g262e4a93-0.1.1-debug.apk
TAR file kolibri-0.16.1a0.dev0+git.80.g262e4a93.tar.gz
WHL file kolibri-0.16.1a0.dev0+git.80.g262e4a93-py2.py3-none-any.whl

rtibbles
rtibbles reviewed Apr 29, 2024
View reviewed changes
kolibri/core/assets/src/composables/useNow.js

import { ref, onMounted, onUnmounted } from 'kolibri.lib.vueCompositionApi';

export default function useNow(interval = 10000) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To justify the composable, we could use this in the ElapsedTime component as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created a follow-up issue for this in #12114

@AlexVelezLl AlexVelezLl mentioned this pull request Apr 30, 2024
Closed
@marcellamaki marcellamaki requested a review from radinamatic May 2, 2024 14:19
rtibbles
rtibbles reviewed May 3, 2024
View reviewed changes
Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code wise, this is good to go, so just want confirmation of the manual fix from QA!

@pcenov
Copy link
Member

pcenov commented May 7, 2024

Hi @AlexVelezLl - I confirm that the syncing status is working correctly. Good to go!

radinamatic
radinamatic approved these changes May 7, 2024
View reviewed changes
Copy link
Member

@radinamatic radinamatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manual QA passes, good to go! 💯 👏🏽 :shipit:

@AlexVelezLl
Copy link
Member Author

Thanks! @pcenov @radinamatic @rtibbles 🎉

@AlexVelezLl AlexVelezLl merged commit cb98c94 into learningequality:release-v0.16.x May 7, 2024
33 of 34 checks passed
@AlexVelezLl AlexVelezLl deleted the fix-update-last-sync branch May 7, 2024 13:51
@AlexVelezLl AlexVelezLl mentioned this pull request May 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rtibbles rtibbles rtibbles left review comments

@radinamatic radinamatic radinamatic approved these changes

@marcellamaki marcellamaki Awaiting requested review from marcellamaki

Assignees
No one assigned
Labels
DEV: frontend SIZE: small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AlexVelezLl @pcenov @radinamatic @rtibbles