Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add duplicate log consolidation to sync hooks. #12131

Merged
merged 1 commit into from
May 9, 2024
Merged

Add duplicate log consolidation to sync hooks. #12131

merged 1 commit into from
May 9, 2024

Conversation

rtibbles
Copy link
Member

@rtibbles rtibbles commented May 4, 2024

Summary

  • Adds missed duplicate log consolidation in sync hooks

@rtibbles rtibbles added the TODO: needs review Waiting for review label May 4, 2024
@rtibbles rtibbles added this to the Kolibri 0.16: Planned Patch 2 milestone May 4, 2024
@rtibbles rtibbles requested a review from bjester May 4, 2024 22:24
@github-actions github-actions bot added DEV: backend Python, databases, networking, filesystem... SIZE: small labels May 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 4, 2024

Build Artifacts

Asset type Download link
PEX file kolibri-0.16.2b1.dev0_git.6.ga02ed541.pex
Windows Installer (EXE) kolibri-0.16.2b1.dev0+git.6.ga02ed541-windows-setup-unsigned.exe
Debian Package kolibri_0.16.2b1.dev0+git.6.ga02ed541-0ubuntu1_all.deb
Mac Installer (DMG) kolibri-0.16.2b1.dev0+git.6.ga02ed541-0.4.1.dmg
Android Package (APK) kolibri-0.16.2b1.dev0+git.6.ga02ed541-0.1.2-debug.apk
TAR file kolibri-0.16.2b1.dev0+git.6.ga02ed541.tar.gz
WHL file kolibri-0.16.2b1.dev0+git.6.ga02ed541-py2.py3-none-any.whl

bjester
bjester approved these changes May 6, 2024
View reviewed changes
Copy link
Member

@bjester bjester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would @radinamatic or @pcenov please test for syncing regressions?

@pcenov
Copy link
Member

pcenov commented May 8, 2024

LGTM - no issues with syncing observed while regression testing.

radinamatic
radinamatic approved these changes May 8, 2024
View reviewed changes
Copy link
Member

@radinamatic radinamatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Syncing not affected by this change, good to go! 👍🏽 :shipit:

@marcellamaki marcellamaki merged commit 6daf78c into learningequality:release-v0.16.x May 9, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radinamatic radinamatic radinamatic approved these changes

@bjester bjester bjester approved these changes

Assignees

@radinamatic radinamatic

Labels
DEV: backend Python, databases, networking, filesystem... SIZE: small TODO: needs review Waiting for review
Projects
None yet
Milestone
Kolibri 0.16: Planned Patch 2
Development

Successfully merging this pull request may close these issues.
5 participants
@rtibbles @pcenov @bjester @radinamatic @marcellamaki