-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align metadata dropdown order to the figma spec #12161
Align metadata dropdown order to the figma spec #12161
Conversation
…array for correct dropdown order, and use this function in the grade levels and accessiblity options dropdown menu creation
Build Artifacts
|
@pcenov @radinamatic this is ready for manual QA. please let me know if you need any additional details |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, manual QA for merge!
Hi @marcellamaki - LGTM - here's what I am seeing for both Level and Accessibility (having selected all possible options when I created the resources in Studio): A note that in the Accessibility drop-down some of the options are always displayed truncated with ellipsis while in the spec the text goes on the next line. Also on closer inspection I noticed that in all browsers the descenders of the letters (specifically the 'g's) are not fully visible - wondering whether that warrants filing a separate issue? |
Yes, @pcenov if you could file a follow up that includes both of those points, that would be fantastic! thank you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Follow up issues for non-regressions filed, this can is good to go! 👏🏽 💯
3d44bd9
into
learningequality:release-v0.16.x
Summary
The list order for the accessibility, and (perhaps more relevantly) grade/level dropdown filters had never been implemented to spec. This creates a helper function to
References
Fixes #12057
Reviewer guidance
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)