-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coach loading state reports #12178
Merged
marcellamaki
merged 4 commits into
learningequality:release-v0.16.x
from
marcellamaki:coach-loading-state-reports
May 15, 2024
Merged
Coach loading state reports #12178
marcellamaki
merged 4 commits into
learningequality:release-v0.16.x
from
marcellamaki:coach-loading-state-reports
May 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onsistent variable naming. Solves flashing unnecessary 'reload' when moving between tabs
github-actions
bot
added
APP: Coach
Re: Coach App (lessons, quizzes, groups, reports, etc.)
DEV: frontend
labels
May 15, 2024
Build Artifacts
|
rtibbles
reviewed
May 15, 2024
kolibri/plugins/coach/assets/src/views/reports/ExerciseQuestionListPageBase.vue
Outdated
Show resolved
Hide resolved
rtibbles
approved these changes
May 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes check out.
marcellamaki
merged commit May 15, 2024
b3cb256
into
learningequality:release-v0.16.x
34 checks passed
Looks and feels much better, was able to identify just a couple of issues and filed a follow-up issue here: #12180 |
This was referenced May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Makes some small improvements to loading state management. (There may be other places where we see similar scenarios that are just not found yet due to lingering coach tech debt in loading state).
References
Fixes #12126
Fixes #11856
(hopefully)
Reviewer guidance
Linked PRs have more relevant screengrabs/guidance to better understand the scenarios
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)