Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lesson Summary children routes refactor #12852

Conversation

AlexVelezLl
Copy link
Member

Summary

  1. Moves lesson edit children routes to be children of the LessonSummaryPage.
  2. Updates SidePanel render pattern according to Quiz creation side panels improvements #12819
  3. Moves router view from lesson creation to LessonSummaryPage.

@github-actions github-actions bot added APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) DEV: frontend labels Nov 18, 2024
@marcellamaki marcellamaki self-assigned this Nov 19, 2024
@AllanOXDi
Copy link
Member

AllanOXDi commented Nov 19, 2024

Just noting that this WIP PR #12845 is blocking it. Please do not merge it yet

@marcellamaki
Copy link
Member

@AlexVelezLl - this looks good to me. I am thinking through the best order of operations for open PRs (including what you were saying about the handlers earlier) and I need to check in with @AllanOXDi about his comment above, so not merging yet. But it all looks good to me, and the manual testing of the moved side panels seems to work well.

@marcellamaki marcellamaki merged commit e7b8e4e into learningequality:develop Nov 20, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) DEV: frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants