Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle numpad enter on Sign in page form #7095

Merged
merged 1 commit into from
Jun 24, 2020

Conversation

indirectlylit
Copy link
Contributor

@indirectlylit indirectlylit commented Jun 18, 2020

Summary

On an extended keyboard, pressing the numpad 'enter' key wasn't working during sign-in

before after
2020-06-18 15 57 46 2020-06-18 16 06 23

Reviewer guidance

make sense?


Contributor Checklist

PR process:

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Testing:

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

Reviewer Checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@indirectlylit indirectlylit added this to the 0.14.0 milestone Jun 18, 2020
@indirectlylit indirectlylit added the TODO: needs review Waiting for review label Jun 18, 2020
@codecov
Copy link

codecov bot commented Jun 18, 2020

Codecov Report

Merging #7095 into release-v0.14.x will increase coverage by 0.12%.
The diff coverage is 0.00%.

Impacted Files Coverage Δ
...libri/plugins/user/assets/src/views/SignInPage.vue 35.09% <0.00%> (-0.24%) ⬇️
kolibri/core/tasks/utils.py 89.65% <0.00%> (-3.45%) ⬇️
kolibri/utils/options.py 77.98% <0.00%> (ø)
kolibri/__init__.py 100.00% <0.00%> (ø)
kolibri/core/content/utils/check_schema_db.py 100.00% <0.00%> (+8.69%) ⬆️

@jonboiser jonboiser changed the title handle numpad enter handle numpad enter on Sign in page form Jun 24, 2020
@jonboiser jonboiser merged commit c1ac886 into learningequality:release-v0.14.x Jun 24, 2020
@indirectlylit indirectlylit deleted the numpad branch June 25, 2020 19:22
@jonboiser jonboiser removed the TODO: needs review Waiting for review label Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants