-
Notifications
You must be signed in to change notification settings - Fork 711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate morango pull/push clients with better write locking and better cancellation handling #7251
Separate morango pull/push clients with better write locking and better cancellation handling #7251
Conversation
Codecov Report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could simplify some of this slightly by saving the change in cancellable. This will need a bit of enhancement of the job API to add a save method, so I think we can skip this for now, and clean this up in later refactor.
Overall approach looks sound.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me - have not done any manual testing, but the code changes look right. Let's merge this to do bug bashing on it.
Summary
This PR integrates the latest morango changes in this PR, and only uses the
db_write_task_lock
when data is queuing or dequeuing locally. This also attempts to address cancellation during the stages of a sync task, since we should only allow cancellation when we can expect that the cancellation will occur as expected. For instance, attempting to cancel during a remote dequeuing shouldn't be allowed, as we don't have that control over the remote's processing.Also addresses the issues with blank passwords as shown in #7127 by setting any blank passwords to
NOT_SPECIFIED
when deserializing.No cancel button shown when locally integrating received data, or aka local dequeuing. Also progress is indeterminate.
Reviewer guidance
References
Depends on: learningequality/morango#85
Related: #7125
Resolves: #7127
Contributor Checklist
PR process:
Testing:
Reviewer Checklist
yarn
andpip
)