Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Welcome AI #4283

Merged
merged 3 commits into from
Sep 22, 2023
Merged

Welcome AI #4283

merged 3 commits into from
Sep 22, 2023

Conversation

vkWeb
Copy link
Member

@vkWeb vkWeb commented Sep 18, 2023

Summary

Adds a global getter that returns the value of AI feature flag.

Manual verification steps performed

  1. Import the isAIFeatureEnabled getter to a Vue component & set it as a computed property.
  2. Change status of ai feature flag for a user by admininstration user.
  3. Render that component by logging in with that user and check computed properties.
  4. isAIFeatureEnabled status should be reflected as it was set by admin.

Reviewer guidance

Taking a look at jest unit tests description to make sure the specs meets what we want.

References

Closes #4276.


Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@vkWeb vkWeb requested a review from akolson September 18, 2023 09:41
@vkWeb
Copy link
Member Author

vkWeb commented Sep 18, 2023

@akash5100 tagging you so that you can also take a look and see if the changes are correct since you and Samson sir the one most involved into AI features for studio.

Copy link
Member

@akolson akolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @vkWeb. Changes look great. I however, lack context on the hasFeatureEnabled and request @bjester to have a look too before the approval and merge can happen.

@akolson akolson requested a review from bjester September 18, 2023 11:21
@akolson akolson self-assigned this Sep 18, 2023
@vkWeb
Copy link
Member Author

vkWeb commented Sep 21, 2023

@bjester @akolson ready to merge 🎉

Copy link
Member

@akolson akolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look correct. Thanks @vkWeb!

@akolson akolson merged commit 87b5413 into learningequality:unstable Sep 22, 2023
@akolson akolson mentioned this pull request Aug 13, 2024
@akolson akolson mentioned this pull request Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a global getter that references the AI Flag in studio
3 participants