-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve errors reporting in edit modal #4404
Improve errors reporting in edit modal #4404
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @FidalMathew! 👋
This is pretty exciting, we'll finally have more specific error messages in the edit view 🎉. The code overall looks good! I have left you some comments to take into account small details.
contentcuration/contentcuration/frontend/channelEdit/components/edit/EditView.vue
Outdated
Show resolved
Hide resolved
contentcuration/contentcuration/frontend/channelEdit/components/edit/EditView.vue
Outdated
Show resolved
Hide resolved
contentcuration/contentcuration/frontend/channelEdit/components/edit/EditView.vue
Outdated
Show resolved
Hide resolved
contentcuration/contentcuration/frontend/channelEdit/components/edit/EditView.vue
Show resolved
Hide resolved
contentcuration/contentcuration/frontend/channelEdit/components/edit/EditView.vue
Outdated
Show resolved
Hide resolved
contentcuration/contentcuration/frontend/channelEdit/components/edit/EditView.vue
Show resolved
Hide resolved
contentcuration/contentcuration/frontend/channelEdit/components/edit/EditView.vue
Outdated
Show resolved
Hide resolved
@AlexVelezLl thank you for the review and quick response. I have made the changes, could you review them? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! @FidalMathew Thank you! Code looks good to me! And I think the scroll behavior is as expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Summary
Description of the change(s) you made
The approach used to improve error reporting in the edit modal is by getting all the errors list. Mapping that errorsList with their names and reference objects. Using that reference object we'll be using scrollIntoView to allow the user to direct themselves to the required input left blank.
Manual verification steps performed
Screenshots (if applicable)
Does this introduce any tech-debt items?
Some changes that needs to add to the current PR are:
scrollIntoView
moves into view a bit below the actual input element.Reference
The PR is in reference with issue: #2924
Reviewer guidance
How can a reviewer test these changes?
Contributor's Checklist
PR process:
CHANGELOG
label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later timedocs
label has been added if this introduces a change that needs to be updated in the user docs?requirements.txt
files also included in this PRStudio-specifc:
notranslate
class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages
,components
, andlayouts
directories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarn
andpip
)