-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added missing checkbox label #4512
Conversation
Thank you, @BabyElias! For context for reviewers, the issue this PR is resolving may be a regression related to recent #4472 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code changes work! But I think, we should be consistent with how we are using HelpTooltip in other places of the code i.e it should be within a <template>
.
contentcuration/contentcuration/frontend/channelList/views/Channel/CatalogFilters.vue
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @BabyElias.
Thanks both! |
Description of the change(s) you made
Added missing checkbox label text
Screenshots (if applicable)
Before :
After :
Does this introduce any tech-debt items?
No
Reviewer guidance
Contributor's Checklist
PR process:
CHANGELOG
label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later timedocs
label has been added if this introduces a change that needs to be updated in the user docs?requirements.txt
files also included in this PRStudio-specifc:
notranslate
class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages
,components
, andlayouts
directories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarn
andpip
)