Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes the disabled save search link #4719

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

akolson
Copy link
Member

@akolson akolson commented Sep 9, 2024

Summary

Description of the change(s) you made

This pr fixes the 'Save search' link that was disabled if one hadn't previously saved the same search term.

Manual verification steps performed

  1. Go to https://unstable.studio.learningequality.org/en/accounts/#/ and sign in
  2. Open a channel and click Add > Import from other channels
  3. Enter a search term and click the Search button
  4. Attempt to click the 'Save search link' and observe that it's disabled for no obvious reason

Screenshots (if applicable)

Screen.Recording.2024-09-10.at.00.05.54.mov

Does this introduce any tech-debt items?

  • No

Reviewer guidance

How can a reviewer test these changes?

  • See manual verification steps

Are there any risky areas that deserve extra testing?

  • Saving and viewing a search

References

Fixes #4711

Comments


Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@akolson akolson added this to the Studio: Bulk Editing Release milestone Sep 9, 2024
@akolson akolson changed the title fixes disabling of the save search link Fixes the disabled save search link Sep 9, 2024
Copy link
Member

@LianaHarris360 LianaHarris360 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Save Search action link is correctly disabled when the current search has already been saved, and it can be clicked otherwise.

I just want to note that if you erase the text in the search input box, you can still click Save search; however, it will save the last text that was actually searched, which appears to be the intended behavior.

SavedSearchBehavior.mov

@akolson
Copy link
Member Author

akolson commented Sep 11, 2024

Thanks @LianaHarris360 for the review and for raising this. It looks like we will need to improve the user experience of the save search feature but this should be sufficient for now. cc @marcellamaki

@akolson akolson merged commit fd98799 into learningequality:unstable Sep 11, 2024
13 checks passed
@akolson akolson mentioned this pull request Sep 13, 2024
@akolson akolson mentioned this pull request Oct 1, 2024
@akolson akolson deleted the fix-disabled-save-search branch October 31, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unstable - Import from other channels - The 'Save search' option is disabled
3 participants