Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Used KTextTruncator in ReviewSelectionsPage to avoid text collision #4870

Draft
wants to merge 3 commits into
base: unstable
Choose a base branch
from

Conversation

shruti862
Copy link
Contributor

Summary

Added KTextTruncator in ReviewSelectionsPage to avoid resource title collision with Channel name.
After Change:
Screenshot from 2025-01-15 19-41-36

References

Fixes issue #4086

Reviewer guidance

@MisRob MisRob requested a review from ozer550 January 15, 2025 18:49
@ozer550 ozer550 self-assigned this Jan 27, 2025
Copy link
Member

@ozer550 ozer550 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested the changes locally and the text collision does not exist now. Thanks @shruti862!

@MisRob MisRob self-assigned this Jan 28, 2025
Copy link
Member

@MisRob MisRob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @shruti862, thanks! Even though this resolved the text collision, there is a regression. Previously, items in the list would be formatted as links, and clicking the item would open a resource. This functionality is now lost. #4086 needs to be fixed in a way that doesn't break this.

I believe that in #4591, @lokesh-sagi125 works on some other places that need KTextTruncator and is currently dealing with some things related to ActionLink and KTextTruncator that could perhaps be relevant here as well. @lokesh-sagi125 would you coordinate with @shruti862 and mention more details?

@lokesh-sagi125
Copy link

yes @MisRob even though my implementation is still acting like a link , the underline part is not inherited. will try researching other possible solutions:)

@MisRob MisRob requested review from MisRob and ozer550 February 11, 2025 10:21
@shruti862 shruti862 marked this pull request as draft February 11, 2025 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants