Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add m1 support #234

Merged
merged 1 commit into from
Dec 12, 2022
Merged

Add m1 support #234

merged 1 commit into from
Dec 12, 2022

Conversation

danielgatis
Copy link
Contributor

@danielgatis danielgatis commented Dec 2, 2022

This PR:

  • Updates the nokogiri gem and sanitize gem to add support to m1 processors.
  • Adds an ENV var to set the yarn path.

rubys/nokogumbo#183

@danielgatis danielgatis self-assigned this Dec 2, 2022
@paranoicsan paranoicsan added the enhancement New feature or request label Dec 6, 2022
Copy link
Collaborator

@paranoicsan paranoicsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

I think we can squash it into single commit, rebase on top of master branch and add a note about new ENV variable.

lib/tasks/lcms/engine_tasks.rake Show resolved Hide resolved
Copy link
Collaborator

@paranoicsan paranoicsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Please squash and we will merge it.

@codeclimate
Copy link

codeclimate bot commented Dec 8, 2022

Code Climate has analyzed commit 79dae7f and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (10% is the threshold).

This pull request will bring the total coverage in the repository to 52.6% (0.0% change).

View more on Code Climate.

@paranoicsan paranoicsan merged commit 6382368 into master Dec 12, 2022
@paranoicsan paranoicsan deleted the add-m1-support branch December 12, 2022 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants