feat: Add submit form on pressing enter, Closes #154 #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyranjamie
force-pushed
the
fire-on-return
branch
from
d617a6a
to
eb75c05
Compare
markmhendrickson
requested review from
aulneau
and removed request for
hstove
hstove
approved these changes
Feb 25, 2020
aulneau
approved these changes
Feb 25, 2020
|
Can this be merged, though? Or should we wait for monorepo to be fully functional? |
|
@hstove will make this change in the monorepo |
|
Closing - changes ported in #235 |
kyranjamie
pushed a commit
that referenced
this pull request
Aug 26, 2024
## [6.46.0](v6.45.2...v6.46.0) (2024-08-26) ### Features * change balance load logic, closes leather-io/issues[#227](#227) ([faf71fb](faf71fb)) ### Bug Fixes * add default true to show settings to make sure it shows for locked screens, closes [#5777](#5777) ([96b2990](96b2990)) * do not capitalise add network ([5258d7e](5258d7e)) * empty space in settings dropdown ([d33df6f](d33df6f)) * failing ledger test ([67799fe](67799fe)) * fix formatting of add network ui, closes leather-io/issues[#5735](#5735) ([8a76b5f](8a76b5f)) * fix issues with alignment of page headers ([ea76352](ea76352)) * **ledger:** support stx_signMessage, closes [#5756](#5756) ([92a99ed](92a99ed)) * make headers more composable, prevent logo hover, closes leather-io/issues[#4597](#4597) ([3f2e359](3f2e359)) * minimum bitcoin spend, closes [#5739](#5739) ([34405f6](34405f6)) * prevent illegal constructor error ([a774b66](a774b66)) * remove blockstream from tests and add network form ([86af370](86af370)) * remove card from retrieve taproot ui ([27ca424](27ca424)) * **sentry:** sample performance units, closes leather-io/issues[#249](#249) ([3b6a5d8](3b6a5d8)) * tool to clear submitted tx state ([1e6f63d](1e6f63d)) * update ui library and deprecate footer ([0f5cfa2](0f5cfa2)) * validate dom nesting console error ([fe21fa8](fe21fa8)) ### Internal * differentiate action popup and popup, improve responsiveness and refactor footers, ref [#5260](#5260) ([2cae2a2](2cae2a2)) * hide lock option if wallet already locked ([b43cf8b](b43cf8b)) * post-release merge back ([686a823](686a823)) * remove back button on unlock screen and remove fragment ([9bc13ab](9bc13ab)) * update monorepo dependancies ([427f82f](427f82f)) * update prettier ([9e7d404](9e7d404)) * update tanstack libraries ([1486f5c](1486f5c))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Didn't figure out how to do this with the
keyCode, isn't in the event (even with.persist()). But checking input for line return char works well.On pressing return, check for line return, if it's there, blur text area and submit form.