Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Signing Transaction via Ledger #5756

Closed
MicaiahReid opened this issue Aug 15, 2024 · 1 comment · Fixed by #5757
Closed

Enable Signing Transaction via Ledger #5756

MicaiahReid opened this issue Aug 15, 2024 · 1 comment · Fixed by #5757

Comments

@MicaiahReid
Copy link

Currently, Leather prevents signing transactions via Ledger (source). Is this check something that could be removed?

I'm creating an application that helps developers manage contract operations and deployments, and it would be great for them to be able to use Leather. This feature works with xverse, so users that want to use a ledger with our app can only use xverse.

@kyranjamie
Copy link
Collaborator

Hi @MicaiahReid thanks for the reminder. I've opened a PR here that adds Ledger support for this endpoint #5757

kyranjamie pushed a commit that referenced this issue Aug 26, 2024
## [6.46.0](v6.45.2...v6.46.0) (2024-08-26)

### Features

* change balance load logic, closes leather-io/issues[#227](#227) ([faf71fb](faf71fb))

### Bug Fixes

* add default true to show settings to make sure it shows for locked screens, closes [#5777](#5777) ([96b2990](96b2990))
* do not capitalise add network ([5258d7e](5258d7e))
* empty space in settings dropdown ([d33df6f](d33df6f))
* failing ledger test ([67799fe](67799fe))
* fix formatting of add network ui, closes leather-io/issues[#5735](#5735) ([8a76b5f](8a76b5f))
* fix issues with alignment of page headers ([ea76352](ea76352))
* **ledger:** support stx_signMessage, closes [#5756](#5756) ([92a99ed](92a99ed))
* make headers more composable, prevent logo hover, closes leather-io/issues[#4597](#4597) ([3f2e359](3f2e359))
* minimum bitcoin spend, closes [#5739](#5739) ([34405f6](34405f6))
* prevent illegal constructor error ([a774b66](a774b66))
* remove blockstream from tests and add network form ([86af370](86af370))
* remove card from retrieve taproot ui ([27ca424](27ca424))
* **sentry:** sample performance units, closes leather-io/issues[#249](#249) ([3b6a5d8](3b6a5d8))
* tool to clear submitted tx state ([1e6f63d](1e6f63d))
* update ui library and deprecate footer ([0f5cfa2](0f5cfa2))
* validate dom nesting console error ([fe21fa8](fe21fa8))

### Internal

* differentiate action popup and popup, improve responsiveness and refactor footers, ref [#5260](#5260) ([2cae2a2](2cae2a2))
* hide lock option if wallet already locked ([b43cf8b](b43cf8b))
* post-release merge back ([686a823](686a823))
* remove back button on unlock screen and remove fragment ([9bc13ab](9bc13ab))
* update monorepo dependancies ([427f82f](427f82f))
* update prettier ([9e7d404](9e7d404))
* update tanstack libraries ([1486f5c](1486f5c))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants