Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: psychadelic walrus #5798

Merged
merged 31 commits into from
Aug 26, 2024
Merged

release: psychadelic walrus #5798

merged 31 commits into from
Aug 26, 2024

Conversation

@pete-watters
Copy link
Contributor Author

@fbwoolf @alter-eggo @edgarkhanzadian:

This release should also contain some package updates #5793. For the UI library update there is a breaking change that needs to first merge this #5796

It would be great if we could also include #5785

@fbwoolf
Copy link
Contributor

fbwoolf commented Aug 21, 2024

@fbwoolf @alter-eggo @edgarkhanzadian:

This release should also contain some package updates #5793. For the UI library update there is a breaking change that needs to first merge this #5796

It would be great if we could also include #5785

Once these are all merged here, I can test the build and approve.

@pete-watters
Copy link
Contributor Author

@fbwoolf @alter-eggo @edgarkhanzadian:
This release should also contain some package updates #5793. For the UI library update there is a breaking change that needs to first merge this #5796
It would be great if we could also include #5785

Once these are all merged here, I can test the build and approve.

Thanks @fbwoolf 👍 The last outstanding PR is this one to manually update the packages as the bot PR failed #5799

@pete-watters pete-watters self-assigned this Aug 21, 2024
@fbwoolf
Copy link
Contributor

fbwoolf commented Aug 21, 2024

I tested the build here and seems good, are the alignment issues in the header captured in an issue somewhere? The Leather logo is off at times to the left, while the menu icon is sometimes out of alignment on the right. I do see this in production though too...

Screenshot 2024-08-21 at 7 36 02 PM Screenshot 2024-08-21 at 7 36 47 PM

@pete-watters
Copy link
Contributor Author

pete-watters commented Aug 22, 2024

I tested the build here and seems good, are the alignment issues in the header captured in an issue somewhere? The Leather logo is off at times to the left, while the menu icon is sometimes out of alignment on the right. I do see this in production though too...

Screenshot 2024-08-21 at 7 36 02 PM Screenshot 2024-08-21 at 7 36 47 PM

Thanks @fbwoolf. I think that's a follow on bug from the previous release that's not captured anywhere. Let me take a look at that now in case it's something I can fix quickly and include here.

I opened a bug for it #5802 and have a draft PR #5801

@pete-watters pete-watters merged commit c41ece1 into main Aug 26, 2024
71 checks passed
@pete-watters pete-watters deleted the release/psychadelic-walrus branch August 26, 2024 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants