Fix vertical offset of dismissal option for hardware device connection view

[markmhendrickson]

Screen.Recording.2024-08-07.at.12.34.07.mov

[markmhendrickson]

Also seen in this state:

[pete-watters]

I took a look at this as I will update the UI library anyway and it is quick to solve but adding good value. The problem is not having a minimum header height in dialog headers when there is no title.

I just want to double check that the other dialog headers with title have the correct height.

An example of this is Sign out which looks like this:

I can change it to have the same height as the non-title ones or else handle those on a specific case basis. If change them all it will look like this on dialogs with title (slightly taller) :

Here is a video that shows it more clearly:

Area.mp4

Let me know what you think @fabric-8 @markmhendrickson @mica000

[pete-watters]

@fabric-8 confirmed it's OK here: https://trustmachines.slack.com/archives/C05LRS7G44R/p1724170032342449?thread_ts=1724166569.243219&cid=C05LRS7G44R

after checking and from what I can see headers are supposed to have a unit-height of 8.5 (68px) — So yes, I think you could apply that same logic to title-less headers with (ie header with just a close button)

[pete-watters]

I merged a fix to the mono repo UI library. Next I need to update this in the extension

[pete-watters]

Extension integration PR open here

[markmhendrickson]

Should we add a (screenshot-based) integration test for this fix?

[pete-watters]

Should we add a (screenshot-based) integration test for this fix?

We should. I will investigate screenshot based testing in here https://github.com/leather-io/issues/issues/264 and include this