Show HTML previews for inscriptions (e.g. recursive) #4077
Comments
markmhendrickson
added
Enhancement 💡
enhancement-p2
|
If we want to use this solution to show this inscription As it is displayed on ord.io: https://www.ord.io/bc1pd4fjc9cyg8wfgc3x7d3pcxc99tmn6vqw5gstp6hhmputm06rw2tqdqdtxd Are there any changes needed from the ordinals-api too? Or rather the explorer so it is displayed there similarly too? @rafaelcr |
|
@kyranjamie thoughts here on whether we can embed HTML previews safely in the wallet somehow, or whether we need to request a preview image (perhaps animated) from the API that can be used instead? |
|
I would be reluctant to add Embeddable content just seems like it'd create such as cess pit of scammers. |
|
@kyranjamie I agree we do not want to create such a hole in the wallet for scammers to take advantage of. We should still show some placeholder in the wallet, perhaps even a warning/explanation about the type of ordinal? |
|
I see this PR for embedding iframes which can resolve this #4077 This recursive inscription doesn't load in that build (4269). Perhaps it is using something else. It should be displaying several .svg files on top of each other. Should this be covered by this PR or would that require a different kind of enhancement? Example inscription: https://ordinals.hiro.so/inscription/6795bcea8de910906a20643a300484005b3df113a9246a43b7408efb8a0036a7i0 |
|
Another example of recursive inscriptions that do no currently show in the wallet, they will appear blank or black.
Here are two more examples of an ordinal that doesn't show yet on the Hiro explorer and the code it uses:
This is the original inscription being expected to be displayed recursively via the code in This is an example of an ordinal showing up black in the wallet, although displaying correctly on explorer.hiro.so:
This is what is displayed in ordiscan.com (see code and submodules, avif and js) Is it safe to show this in the wallet? if not can we display a message about that in the wallet instead to help users understand why it is blank/black instead of displaying their inscription image? |
|
The owner of this inscription would like this displayed as an image if possible. It is a cursed recursive inscription:
https://www.ord.io/81433a25e784366a7db917af98393be6eba232a03646e1fc072904fc3b8803b2i2 |
|
We discussed this earlier this week with @kyranjamie and @janniks and concluded that it seems safe to attempt an iframing approach for HTML inscriptions, one in which iframes are loaded only when in view / within the viewport, to avoid possible performance issues to loading many on a given screen as the user scrolls. |
## [6.21.0](v6.20.0...v6.21.0) (2023-12-19) ### Features * html video and audio inscription types, closes [#4077](#4077) and [#3556](#3556) ([e19eea4](e19eea4)) * modified contracts and balance fetching ([63d29ba](63d29ba)) * updated dlc tools version ([8dc1d22](8dc1d22)) ### Bug Fixes * collectibles refetch, closes [#4413](#4413) ([13aa68f](13aa68f)) * deprecate legacy font sizes, closes [#4587](#4587) ([5f539ca](5f539ca)) * handle inscription type svg, ref [#4727](#4727) ([b713c70](b713c70)) * only show swaps option on mainnet, closes [#4687](#4687) ([af6443c](af6443c)) * swaps test, ref [#4725](#4725) ([faae457](faae457)) * **wallet:** fees warning alignment fix ([d771bcc](d771bcc)) ### Internal * post-release merge back ([75f4998](75f4998))
## [6.21.0](leather-io/extension@v6.20.0...v6.21.0) (2023-12-19) ### Features * html video and audio inscription types, closes [leather-io#4077](leather-io#4077) and [leather-io#3556](leather-io#3556) ([e19eea4](leather-io@e19eea4)) * modified contracts and balance fetching ([63d29ba](leather-io@63d29ba)) * updated dlc tools version ([8dc1d22](leather-io@8dc1d22)) ### Bug Fixes * collectibles refetch, closes [leather-io#4413](leather-io#4413) ([13aa68f](leather-io@13aa68f)) * deprecate legacy font sizes, closes [leather-io#4587](leather-io#4587) ([5f539ca](leather-io@5f539ca)) * handle inscription type svg, ref [leather-io#4727](leather-io#4727) ([b713c70](leather-io@b713c70)) * only show swaps option on mainnet, closes [leather-io#4687](leather-io#4687) ([af6443c](leather-io@af6443c)) * swaps test, ref [leather-io#4725](leather-io#4725) ([faae457](leather-io@faae457)) * **wallet:** fees warning alignment fix ([d771bcc](leather-io@d771bcc)) ### Internal * post-release merge back ([75f4998](leather-io@75f4998))
https://ordinals.hiro.so/sat/390660864168
https://docs.ordinals.com/inscriptions.html#sandboxing
The text was updated successfully, but these errors were encountered: