Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "Learn more" from PSBT warning until we have user guide to link #4607

Closed
markmhendrickson opened this issue Nov 30, 2023 · 0 comments · Fixed by #4629
Closed

Remove "Learn more" from PSBT warning until we have user guide to link #4607

markmhendrickson opened this issue Nov 30, 2023 · 0 comments · Fixed by #4629
Assignees
Labels
area:psbts bug Functionality broken bug-p2 Critical functionality broken for few users, with no clear workarounds

Comments

@markmhendrickson
Copy link
Collaborator

Currently it goes nowhere:

Screenshot 2023-11-30 at 12 53 41

We plan to create a guide here and can add the link back to the UI once published.

@markmhendrickson markmhendrickson added bug Functionality broken bug-p2 Critical functionality broken for few users, with no clear workarounds area:psbts labels Nov 30, 2023
@pete-watters pete-watters linked a pull request Dec 4, 2023 that will close this issue
kyranjamie pushed a commit that referenced this issue Dec 5, 2023
## [6.18.0](v6.17.0...v6.18.0) (2023-12-05)

### Features

* add tests for psbt sigining ([c5ee6b7](c5ee6b7))
* modified explorer link maker function to have a regtest option ([4b158d2](4b158d2))
* use-explorer-link got separated into bitcoin and stacks function variant ([89bd3c5](89bd3c5))

### Bug Fixes

* add color to warning background, closes [#4600](#4600) ([cdcc597](cdcc597))
* adjust position of fee slot, closes [#4462](#4462) ([fc2e08a](fc2e08a))
* change to hstack to align buttons, closes [#4592](#4592) ([d00d83f](d00d83f))
* decouple choose crypto asset components and add a new lint rule ([7b11213](7b11213))
* make sure pending transactions have the correct circle colour, closes [#4591](#4591) ([eb96ac2](eb96ac2))
* remove PSBT learn more link, closes [#4607](#4607) ([1d9fd60](1d9fd60))
* roll back move to async from PR 4490 to supress sentry error ([9ec8a0c](9ec8a0c))
* set backgroundLocation for send ordinal, closes [#4562](#4562) ([b104a48](b104a48))
* underlaid button, closes [#4615](#4615) ([907f33c](907f33c))

### Internal

* consume design tokens from extension ([d476fa3](d476fa3))
* consume design tokens from extension ([0e52e5f](0e52e5f))
* improve icons ([fcbf0d7](fcbf0d7))
* post-release merge back ([34f5553](34f5553))
pete-watters added a commit to Nithishvb/extension that referenced this issue Jan 17, 2024
pete-watters pushed a commit to Nithishvb/extension that referenced this issue Jan 17, 2024
## [6.18.0](leather-io/extension@v6.17.0...v6.18.0) (2023-12-05)

### Features

* add tests for psbt sigining ([c5ee6b7](leather-io@c5ee6b7))
* modified explorer link maker function to have a regtest option ([4b158d2](leather-io@4b158d2))
* use-explorer-link got separated into bitcoin and stacks function variant ([89bd3c5](leather-io@89bd3c5))

### Bug Fixes

* add color to warning background, closes [leather-io#4600](leather-io#4600) ([cdcc597](leather-io@cdcc597))
* adjust position of fee slot, closes [leather-io#4462](leather-io#4462) ([fc2e08a](leather-io@fc2e08a))
* change to hstack to align buttons, closes [leather-io#4592](leather-io#4592) ([d00d83f](leather-io@d00d83f))
* decouple choose crypto asset components and add a new lint rule ([7b11213](leather-io@7b11213))
* make sure pending transactions have the correct circle colour, closes [leather-io#4591](leather-io#4591) ([eb96ac2](leather-io@eb96ac2))
* remove PSBT learn more link, closes [leather-io#4607](leather-io#4607) ([1d9fd60](leather-io@1d9fd60))
* roll back move to async from PR 4490 to supress sentry error ([9ec8a0c](leather-io@9ec8a0c))
* set backgroundLocation for send ordinal, closes [leather-io#4562](leather-io#4562) ([b104a48](leather-io@b104a48))
* underlaid button, closes [leather-io#4615](leather-io#4615) ([907f33c](leather-io@907f33c))

### Internal

* consume design tokens from extension ([d476fa3](leather-io@d476fa3))
* consume design tokens from extension ([0e52e5f](leather-io@0e52e5f))
* improve icons ([fcbf0d7](leather-io@fcbf0d7))
* post-release merge back ([34f5553](leather-io@34f5553))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:psbts bug Functionality broken bug-p2 Critical functionality broken for few users, with no clear workarounds
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants