Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update corner radius scale and components #4637

Closed
1 of 2 tasks
mica000 opened this issue Dec 4, 2023 · 5 comments · Fixed by #4804
Closed
1 of 2 tasks

Update corner radius scale and components #4637

mica000 opened this issue Dec 4, 2023 · 5 comments · Fixed by #4804
Assignees
Labels
area:ui UI engineering specific tasks. enhancement-p3 Non-critical functionality wanted by many users, or there are clear alternatives

Comments

@mica000
Copy link

mica000 commented Dec 4, 2023

New corner radius scale:

  • XS: 2px – buttons, rows, collectibles images;
  • SM: 4px – menus, drop-down, inputs;
  • MD: 8px – modals and drawers;
  • LG: 12px – page container;

Task:

  • Create new scale for corner radius
  • Update components

FINAL PROPOSAL: OPTION 1
https://www.figma.com/file/2MLHeIeL6XPVi3Tc2DfFCr/%E2%9D%96-Leather-%E2%80%93-Design-System?type=design&node-id=9972-108739&mode=design&t=oU8qhxS
border radius

@mica000 mica000 added the area:ui UI engineering specific tasks. label Dec 4, 2023
@mica000 mica000 self-assigned this Dec 4, 2023
@mica000 mica000 changed the title Update border radius scale and components Update corder radius scale and components Dec 4, 2023
@mica000 mica000 changed the title Update corder radius scale and components Update corner radius scale and components Dec 4, 2023
@mica000 mica000 removed their assignment Dec 6, 2023
@markmhendrickson markmhendrickson added Enhancement 💡 enhancement-p3 Non-critical functionality wanted by many users, or there are clear alternatives labels Dec 22, 2023
@fbwoolf fbwoolf self-assigned this Jan 10, 2024
@fbwoolf
Copy link
Contributor

fbwoolf commented Jan 11, 2024

@mica000 it appears in our tokens we have an xl = 20px and an xxl = 24px, are those ones we need to keep?

@fbwoolf
Copy link
Contributor

fbwoolf commented Jan 11, 2024

It looks like xl is used when we display some things with tx requests (like structured data), and xxl is used just to round out a pill or badge.

EDIT: Thinking these can be removed and edge cases hardcoded separately?

@mica000
Copy link
Author

mica000 commented Jan 11, 2024

Hi! I think Fab set the tokens to 100px so they are always rounded.
https://www.figma.com/file/2MLHeIeL6XPVi3Tc2DfFCr/%E2%9D%96-Leather-%E2%80%93-Design-System?type=design&node-id=1574-27&mode=design&t=7LgsZQErfHZlucS9-4

We do however have collectibles that have a 2px radius, so maybe this rule shouldn’t apply to them?

Let me know if I understood what you mean correctly.

@fbwoolf
Copy link
Contributor

fbwoolf commented Jan 12, 2024

Let me know if I understood what you mean correctly.

Ha, have no idea what you are responding to here - lol. I am updating all radii (tokens). We currently use an xl and xxl, but in the description of this issue those are not included, and in Figma they both have a ?? by them. Are those supposed to be removed as radii tokens?

@fbwoolf fbwoolf linked a pull request Jan 13, 2024 that will close this issue
@mica000
Copy link
Author

mica000 commented Jan 15, 2024

Ah got it! hehe
The xl and xxl are with ?? because we wanted to removed them since the new scale wasn’t using them (forgot to remove the ?? from the handover docs.) Instead, whenever something is rounded, fab suggested to se the radius to 100px and I think that would be manual - cc @fab to confirm.

kyranjamie pushed a commit that referenced this issue Jan 16, 2024
## [6.23.0](v6.22.0...v6.23.0) (2024-01-16)

### Features

* improve error handling in ledger, surface incorrect app error ([5bff514](5bff514))
* prompt user to open the app ([f672bec](f672bec))

### Bug Fixes

* add remote config to recover feature ([84a10dc](84a10dc))
* duplicate keys error ([77dc018](77dc018))
* lint for deps ([42179de](42179de))
* remove fee title in increase fee form ([0de3900](0de3900))
* track error codes ([227f6ee](227f6ee))
* **ui:** rebuild tabs with radix primitives, ref [#4309](#4309) ([3b0488e](3b0488e))
* unused exports ([3fff31d](3fff31d))

### Internal

* add improved sentry perf tracking ([8b96e9a](8b96e9a))
* check instance of error before passing it to checkLockedDeviceError ([e342642](e342642))
* post-release merge back ([2eaa09f](2eaa09f))
* quit app ourselves instead of prompting user to do it ([35c2ff1](35c2ff1))
* remove unneeded radix styles ([6808536](6808536))
* reuse getAppAndVersion from bitcoin app instance method ([e894808](e894808))
* select and dropdown, ref [#4798](#4798) ([a82457d](a82457d))
* token radii and keyframe, ref [#4637](#4637) ([e67b61d](e67b61d))
* update panda ([2418a1c](2418a1c))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:ui UI engineering specific tasks. enhancement-p3 Non-critical functionality wanted by many users, or there are clear alternatives
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants