Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: alex swaps #4427

Merged
merged 10 commits into from
Oct 26, 2023
Merged

release: alex swaps #4427

merged 10 commits into from
Oct 26, 2023

Conversation

fbwoolf
Copy link
Contributor

@fbwoolf fbwoolf commented Oct 25, 2023

Try out this version of Leather — download extension builds.

Contents:

@314159265359879
Copy link
Contributor

In this build, when sending this warning, text in is displayed with the same colour as the background (or white). I have to select to see it:
image

It looks like this in 6.11.0
image

@fbwoolf
Copy link
Contributor Author

fbwoolf commented Oct 25, 2023

In this build, when sending this warning, text in is displayed with the same colour as the background (or white). I have to select to see it:

This didn't break here. This is releasing swaps. I think there was some discussion in the design channel about what this color should be? There might be an open issue to fix it?

@314159265359879
Copy link
Contributor

314159265359879 commented Oct 25, 2023

Ow I see. Thanks Fara.

UPDATE LGTM: it looks like I was wrong about the info below, the problem is that the explorer doesn't display "sponsored" properly, it is only visible when selected: (reported here: hirosystems/explorer#1317)
image

I think this transaction should be sent "sponsored"? but it isn't, it is sent with a fee. (there are no other pending transactions and there isn't any STX in the wallet to cover the fee. Normal fees are only used when there is a pending transaction already, is what I understood before).

2023-10-25_23-31-18.mp4

This is expected to show "sponsored" when it is a sponsored transaction.
image
https://explorer.hiro.so/txid/0xc2fc1c40ff4728bed552b6b3dbd051da0b0b75f5ac48d8ca9b325ee8d990faad?chain=mainnet

Copy link
Contributor

@pete-watters pete-watters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@kyranjamie kyranjamie merged commit 35e4f96 into main Oct 26, 2023
89 checks passed
@kyranjamie kyranjamie deleted the release/alex-swaps branch October 26, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prevent undefined link to explorer for Bitcoin transaction on submitted screen
6 participants