Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate icons #4543

Merged
merged 4 commits into from
Nov 22, 2023
Merged

chore: migrate icons #4543

merged 4 commits into from
Nov 22, 2023

Conversation

pete-watters
Copy link
Contributor

@pete-watters pete-watters commented Nov 20, 2023

Try out this version of Leather — download extension builds.

This PR:

  • fixes a console error we were getting for react-icon/fi icons
  • refactors our other icons and improve icons token sizing

@pete-watters pete-watters requested a review from fbwoolf November 20, 2023 16:22
@fbwoolf fbwoolf self-assigned this Nov 21, 2023
@fbwoolf
Copy link
Contributor

fbwoolf commented Nov 21, 2023

@pete-watters I took this over today and have changes locally. I assigned the PR to myself to finish.

@fbwoolf fbwoolf linked an issue Nov 21, 2023 that may be closed by this pull request
@fbwoolf fbwoolf force-pushed the fix/4542/svg-errors branch from 0e23e5e to b5fe9a8 Compare November 22, 2023 01:39
@pete-watters pete-watters marked this pull request as ready for review November 22, 2023 15:56
@fbwoolf fbwoolf force-pushed the fix/4542/svg-errors branch from 6579a77 to bbe55a3 Compare November 22, 2023 18:43
@fbwoolf fbwoolf added this pull request to the merge queue Nov 22, 2023
Merged via the queue into dev with commit 1fa4e6c Nov 22, 2023
26 checks passed
@fbwoolf fbwoolf deleted the fix/4542/svg-errors branch November 22, 2023 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SVG errors on send form
3 participants