-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: nested button error, refactor border radii, change receive modal #4559
Conversation
@@ -7,8 +7,12 @@ interface ReceiveItemListProps { | |||
export function ReceiveItemList({ children, title }: ReceiveItemListProps) { | |||
return ( | |||
<> | |||
{title && <styled.span textStyle="">{title}</styled.span>} | |||
<Divider mt="space.02" /> | |||
{title && ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mica000 - hopefully this looks OK now. The font style wasn't being set either
@@ -18,6 +18,8 @@ export const tokens = defineTokens({ | |||
sm: { value: '10px' }, | |||
md: { value: '12px' }, | |||
lg: { value: '16px' }, | |||
xl: { value: '20px' }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a couple more border radius sizes. We can probably remove these one we determine the style we want.
Some were set as 50%
/ 100%
so I changed these to sensible token sizes. The spinner for example was set to 100%
but the same effect is achieved setting it to lg
The QR code was 18px
but I set it to lg
/ 16px
as I thought it looks OK and I didn't want to add tokens not divisible by 4.
@mica000 @fabric-8 : I spent some time here refactoring the
|
Thanks @pete-watters!!!!! |
@pete-watters thanks for fixing, I may have accidentally done the nested button thing on accident when converting from |
No problem. Some small issues like this are bound to happen 👍 it was still working anyway, just never needed to be as button initially |
This PR has a few changes: