Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Improve visual display of unlock screen #4569

Merged
merged 2 commits into from
Nov 27, 2023
Merged

fix: Improve visual display of unlock screen #4569

merged 2 commits into from
Nov 27, 2023

Conversation

pete-watters
Copy link
Contributor

@pete-watters pete-watters commented Nov 27, 2023 •
edited by github-actions bot
Loading

Try out this version of Leather — download extension builds.

This is a small PR to give more margin to the Continue button in extension mode.

I'll do more work to fix this properly with: #4370

@pete-watters pete-watters linked an issue Nov 27, 2023 that may be closed by this pull request
Fix alignment for unlock screen in modal #4423
Closed
kyranjamie
kyranjamie approved these changes Nov 27, 2023
View reviewed changes
Copy link
Collaborator

@kyranjamie kyranjamie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want this also in full screen mode, though?

@pete-watters
Copy link
Contributor Author

pete-watters commented Nov 27, 2023 •
edited
Loading

Do we want this also in full screen mode, though?

We do. Just adding this interim improvement as it's fast and easy

We actually don't want to push the button down more in full screen and I was mistaken.

In the design in full screen it's close to the input. There is no specific design for extension mode so I assume we want to further improve this as part of adding containers with header/footer

@pete-watters pete-watters added this pull request to the merge queue Nov 27, 2023
Merged via the queue into dev with commit 31ddc89 Nov 27, 2023
26 checks passed
@pete-watters pete-watters deleted the fix/4423/unlock-screen-padding branch November 27, 2023 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyranjamie kyranjamie kyranjamie approved these changes

@fbwoolf fbwoolf Awaiting requested review from fbwoolf

@edgarkhanzadian edgarkhanzadian Awaiting requested review from edgarkhanzadian

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix alignment for unlock screen in modal
2 participants
@pete-watters @kyranjamie