feat: use radix tooltip #4797
feat: use radix tooltip #4797
Conversation
|
Not a big fan of the |
theme/keyframes.ts
Outdated
| @@ -14,4 +14,34 @@ export const keyframes: CssKeyframes = { | |||
| transform: 'translateY(0)', | |||
| }, | |||
| }, | |||
| slideRightAndFade: { | |||
There was a problem hiding this comment.
I just put up a PR in the mono repo, so I can add these there so you can remove them. I moved the other one.
|
Agree about the naming here, and you might ref @kyranjamie's PR for the tabs bc I'm going to refactor the Select and DropdownMenu to follow that one. This one should follow same pattern... |
|
So what I ended up doing here is re-exporting the radix primitives with customized styles but also creating a separate wrapper component called BasicTooltip that i've applied in all of the cases in the repo (as we don't need much customization for a tooltip). Otherwise i would've ended up with a lot of repeatable code all over the repo with tooltip roots, contents, triggers, etc. Let me know if that works for us, otherwise i can just use the re-exported radix primitives instead of BasicTooltip |
edgarkhanzadian
requested review from
kyranjamie,
pete-watters,
alter-eggo and
fbwoolf
edgarkhanzadian
force-pushed
the
feat/use-radix-tooltip
branch
from
c5e9ac5
to
df7869f
Compare
Closes #4506
tooltip.mov