refactor: button and link with stories

[fbwoolf]

Try out this version of Leather — Extension build, Test report

This PR refactors our LeatherButton to Button and separates out a new Link component w/ recipe. I wanted to get this up for review, but I still need to QA all the changes.

TODO:

• Look at if can replace uses of styled.button w/ shared Button
• QA Link component use as replacement for the old Button variant='link' and 'text'
• Add invert styling for Link component

What do people think of the Link variant names: underlined (as default) and text (when not underlined?)

[pete-watters]

Great work here @fbwoolf , thanks for taking this on.

I added some feedback but it LGTM 👍 let me know when it's ready for full review and I can re-check.

I encountered one other link component along the way: ExternalLink. We seem to have that and also ExternalLinkIcon. Maybe we can move these into the one Link story and do a refactor?

We seem to sometimes pass ExternalLinkIcon into InfoCardBtn which we can hopefully replace with Link / Button.

That could be a job for another task but just mentioning now lest I forget

[fbwoolf]

This should be ready to review. I linked an issue here that was opened to address our use of styled.button separate from the old LeatherButton, but I'm not sure we need to do anything to replace those. 🤔 We could create an unstyled variant of the Button, but I'm not sure that is necessary?

[pete-watters]

Great work here @fbwoolf . It's great to get these components in and some great refactors and improvements along the way 🚀

[pete-watters]

This should be ready to review. I linked an issue here that was opened to address our use of styled.button separate from the old LeatherButton, but I'm not sure we need to do anything to replace those. 🤔 We could create an unstyled variant of the Button, but I'm not sure that is necessary?

I added a comment to that task as I'm not sure if we need to do it / the urgency. It could be nice to use the new components for all styled.button / styled.a but then there could be other cases where things are fine as they are.