Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: manage tokens toggle, closes #5974 #5979

Closed
wants to merge 2 commits into from
Closed

fix: manage tokens toggle, closes #5974 #5979

wants to merge 2 commits into from
+7 −1

Conversation

alter-eggo
Copy link
Contributor

@alter-eggo alter-eggo commented Nov 19, 2024 •
edited by leather-bot
Loading

Try out Leather build 5e65e43 — Extension build, Test report, Storybook, Chromatic

This pr fixes manage tokens toggle, when click on switch. Problem is that component is wrapped in pressable, where user-select: none, so we need to add onClick listener on switch to make it work

kyranjamie
kyranjamie approved these changes Nov 19, 2024
View reviewed changes
Copy link
Collaborator

@kyranjamie kyranjamie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but is it correct that the pressable has user-select none in first place?

@alter-eggo
Copy link
Contributor Author

@kyranjamie yeah, it's arguable tbh

@kyranjamie
Copy link
Collaborator

Closing as cherry picked in another PR

@kyranjamie kyranjamie closed this Nov 20, 2024
@alter-eggo alter-eggo deleted the fix/manage-tokens-toggle branch November 20, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyranjamie kyranjamie kyranjamie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alter-eggo @kyranjamie