Implement UI for identity #69

aulneau · 2020-01-28T23:25:16Z

What this does

New Components

Created an Account component that lists out a users accounts
Drawer: the bottom drawer that shows the "this account used in X apps" content
ChooseAccount screen, the page that shows the select an account UI
Username screen, shows the UI for registering a new username, note: no validation currently added.

State

Updated a couple screen enums for route states (choose, username)
Added a couple selectors to start determining if there are local identities
Set the initial screen to username

Misc

Created a hook: useAppDetails
Removed final.tsx as it's now in @blockstack/connect

How to test

Pull down and run this branch of @blockstack/connect
yarn && yarn build && rm -rf node_modules && cd test-app && yarn && yarn start
Pull down this branch of blockstack-app and run yarn dev

Connected to this @blockstack/connect PR.

src/components/drawer/index.tsx

src/components/accounts/index.tsx

kyranjamie · 2020-01-29T19:00:44Z

package.json

  "version": "1.0.0",
-  "description": "A web browser extension starter - based on Typescript, React, Redux, Styled-Component, Webpack, and more. Runs on Chrome and Firefox.",
-  "main": "index.js",
-  "scripts": {


Sorry for pending rant, but:

Can we please 🙏not order our package.json alphabetically? This is the IDE-feature autoformat wild west: alphabetical order is, by far, the least optimal way of ordering this file imo. (I see this is alphabetical except name, desc and version)

The most important and frequent thing I go to check in the package.json, is what scripts I can run. Now they're at the bottom.

When you run npm init it generates a file where name, main entry file and scripts are at the top, and, I would argue, with good reason.

I am fine with this, sure. I use a package called fixpack to automate it and lint it. Happy to move the scripts to the top.

I'm happy to have some logic behind ordering, too.

Interesting, haven't seen this package, and thank would really appreciate that.

A package.json file scrubber for the truly insane.

🤔😂

I'm cool with linting it, just arguing scripts are amongst the most important content of the file.

That said, adding a whole new configuration file to a repo, to lint and sort one configuration file, begs the question to me... what lints the linting configuration file?

That said, adding a whole new configuration file to a repo, to lint and sort one configuration file, begs the question to me... what lints the linting configuration file?

It's not added to the file, it's just a one time thing generally -- npx fixpack. I just prefer to have some logic and consistency, I don't really care what that is :)

Sure, but if we wanna add scripts to the top, consistently....

oh nice, yeah let's do that

kyranjamie · 2020-01-30T10:27:55Z

src/components/onboarding/screens/username.tsx

+  const [error, setError] = useState('');
+  const [loading, setLoading] = useState(false);
+  const [username, setUsername] = useState(
+    () => `${getRandomWord()}-${getRandomWord()}-${getRandomWord()}-${getRandomWord()}`


kyranjamie · 2020-01-30T12:15:05Z

src/store/wallet/types.ts

@@ -1,8 +1,10 @@
 import Wallet from '@blockstack/keychain/dist/wallet';
+import Identity from '@blockstack/keychain/dist/identity';


import { Wallet, Identity } from '@blockstack/keychain';

stacks-archive/keychain#18

hstove · 2020-02-04T05:39:22Z

Update: I've added the logic for showing the warning if re-using a multiplayer app.

It depends on stacks-archive/keychain#19, which is published as a beta.

kyranjamie · 2020-02-04T07:28:57Z

Looks good

The only improvement I'd suggest would be keying the identities by ID in an entities object

{
  entities: {
    <identity_id>: {},
  },
  ids: [<identity_id>],
}

// const selector = ids.map(id => entities[id]);

Would be easier to follow, and less error-prone than using the index.

hstove · 2020-02-04T15:08:02Z

Hey Kyran, I think that's a totally reasonable request. I have a hesitation, though, because the order of your identities is pretty important to keep, especially for cryptographic reasons with how we derive sub-identities from the master keychain. I will try out your suggestion, though, as you have a solution for keeping the order intact while still supporting ID-based lookup.

* fix: Remove Stack component from body * fix: Your secret key, Fixes #86 * fix: Save your SK, Fixes #89 * fix: Connect Fixes #91 * fix: Align with connect's removeal of Stack from Screen * fix: Addresses incorrect font, Fixes #87

* fix: Styling of FAQ section, Closes #90 * fix: Styling of the toast, Closes #88 * feat: Update use of Title inline with @blockstack/connect * use <Title> from connect * update connect version in test-app * update connect version * test-app depends on authenticator dependency version? Co-authored-by: Hank Stoever <hstove@gmail.com>

* fix: Disable spellcheck on secret key field * fix: Incorrect link size * fix: <ExplainerCard> style * fix: Modal header styles, Closes #83 * fix: Preload images, remove loading delay, Closes #104 * fix: Kill unused file * refactor: Chevron to UI lib * fix: Remove implicit import * fix: Replace mdi plus in circle for custom one * fix: Delete duplicate, unused file * dep updates Co-authored-by: Hank Stoever <hstove@gmail.com>

* feat: Add homepage * fix: Add mobile meta tag * refactor: Faciliate list with no action * refactor: Use Sign out term

* fix: Misaligned font size * fix: Misalignment of toast * fix: Add newly used word

markmhendrickson · 2020-02-11T16:44:06Z

This is ready for merge upon which @timstackblock should be assigned #61 for QA.

* fix: Usernames flashing on component refresh, Closes #101 * fix: Shorten huge gitignore * fix: Add padding to bottom of create account

Implement UI for identity

## [6.44.0](v6.43.0...v6.44.0) (2024-07-17) ### Features * add debug command to log hiro limiter data ([52a0c15](52a0c15)) * add runes fiat balance, closes [#5300](#5300) ([0a175f7](0a175f7)) * auto-scale balance font-size to avoid line-break ([b25d5bc](b25d5bc)) ### Bug Fixes * **analytics:** remove query error tracking, too many events ([f3de110](f3de110)) * **analytics:** segment not passing context to mixpanel ([52a6fb2](52a6fb2)) * send forms address error, closes [#5440](#5440) ([0b99130](0b99130)) * show brc20 token fiat balance, closes [#5626](#5626) ([adf8c19](adf8c19)) * stx balance loading condition ([37686a4](37686a4)) ### Internal * post-release merge back ([db89bdd](db89bdd)) * remove bitcoin contracts, closes [#5244](#5244) and leather-io/issues[#69](#69) ([1b9f9a2](1b9f9a2)) * update query cache with known data ([69a4e0c](69a4e0c)) * update query package ([98beec5](98beec5))

## [6.44.1](v6.44.0...v6.44.1) (2024-07-25) ### Bug Fixes * handle long token names gracefully, ref leather-wallet/extension[#5673](#5673) ([3110f7e](3110f7e)) * rate limiting on testnet ([f4258cd](f4258cd)) * security vulnerability with ip pkg in storybook ([85d34b3](85d34b3)) * send inscription flow validation error ([8030d3a](8030d3a)) * stx fallback btn show on load ([95d6ea5](95d6ea5)) * update popup headers to show account info, ref leather-wallet/issues[#157](#157) ([93ad45f](93ad45f)) ### Internal * bitcoin queries, closes leather-io/issues[#94](#94) and leather-io/issues[#101](#101) ([1187acf](1187acf)) * **release:** 6.44.0 ([9fc4eb4](9fc4eb4)), closes [#5300](#5300) [#5440](#5440) [#5626](#5626) [#5244](#5244) [#69](#69) * stacks queries ([5041cfb](5041cfb))

implement UI for identity: username.tsx, choose-account.tsx

f71c34c

aulneau requested a review from hstove January 28, 2020 23:25

aulneau mentioned this pull request Jan 28, 2020

Update screen components hirosystems/connect#25

Merged

kyranjamie reviewed Jan 29, 2020

View reviewed changes

src/components/drawer/index.tsx Outdated Show resolved Hide resolved

kyranjamie reviewed Jan 29, 2020

View reviewed changes

src/components/accounts/index.tsx Outdated Show resolved Hide resolved

aulneau added 4 commits January 29, 2020 09:51

update types, connect version

1d5d1ae

update deps, package.json

09b8024

remove async

2e8704c

code style nit

8aede6f

aulneau requested a review from kyranjamie January 29, 2020 15:59

aulneau added 3 commits January 29, 2020 10:06

merge conflicts

a294e27

attempt tests

8de2921

fix tests

5b1cbff

kyranjamie reviewed Jan 29, 2020

View reviewed changes

hstove added 16 commits January 29, 2020 13:41

actually register username, store in onboarding state

37d80eb

update ChooseAccount to use existing identities

9439cdf

update keychain version

3590b00

when an account is selected, sign in with it

1ebb03f

allow creating a new account on sign in

0b6326c

allow creating a new account and choosing existing

7e29a17

fix typescript issue relating to nested redux props

977490a

prettier fix

1541ea4

fix prettier not auto-saving or fixing

a352d5f

allow strictly passing identity to finish sign in

acafb65

fix tests by not entering username (for now)

5732530

remove unused variable causing ts error

ab57912

also send to select account if sendToSignIn is falsy

8b0b12e

fix bug related to identity serialization

26a3508

fixes bug where you can't add account

68a9ce2

fix bug with magic recovery code flow

726cc6e

kyranjamie reviewed Jan 30, 2020

View reviewed changes

aulneau added 3 commits January 30, 2020 10:16

getRandomWord -> utils

725c0b1

remove comments

ea2e8c3

add fixpackrc, run it

372275b

kyranjamie approved these changes Jan 31, 2020

View reviewed changes

hstove added 5 commits February 3, 2020 21:29

refactor finalizing auth request into redux action

7a2587f

show drawer if username is re-used

ca21907

show existing apps and allow confirming reuse

b414be2

lint errors

d4fe470

update version of keychain

9b37bec

fix: Remove Stack component from body (#94)

59534ae

* fix: Remove Stack component from body * fix: Your secret key, Fixes #86 * fix: Save your SK, Fixes #89 * fix: Connect Fixes #91 * fix: Align with connect's removeal of Stack from Screen * fix: Addresses incorrect font, Fixes #87

hstove mentioned this pull request Feb 4, 2020

Support for walletConfig stacks-archive/keychain#19

Merged

3 tasks

hstove and others added 7 commits February 4, 2020 20:13

use walletConfig for hiding reuse warning

31fc225

fix: Loose dollar sign, Closes #100 (#102)

fbb25e3

feat: Add homepage (#71)

f5b3c1c

* feat: Add homepage * fix: Add mobile meta tag * refactor: Faciliate list with no action * refactor: Use Sign out term

UI improvements (#107)

a6a372d

* fix: Misaligned font size * fix: Misalignment of toast * fix: Add newly used word

fix: Resize buttons (#109)

2eb2bce

Fix names regenerating when creating new account (#108)

34b3702

* fix: Usernames flashing on component refresh, Closes #101 * fix: Shorten huge gitignore * fix: Add padding to bottom of create account

aulneau merged commit c23e92b into master Feb 11, 2020

hstove pushed a commit that referenced this pull request Feb 25, 2020

Merge pull request #69 from blockstack/feature/identity-ui

f461212

Implement UI for identity

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement UI for identity #69

Implement UI for identity #69

aulneau commented Jan 28, 2020 •

edited

Loading

kyranjamie Jan 29, 2020 •

edited

Loading

aulneau Jan 30, 2020

hstove Jan 30, 2020

kyranjamie Jan 30, 2020

kyranjamie Jan 30, 2020

aulneau Jan 30, 2020

kyranjamie Jan 30, 2020

aulneau Jan 30, 2020

kyranjamie Jan 30, 2020

kyranjamie Jan 30, 2020 •

edited

Loading

hstove commented Feb 4, 2020

kyranjamie commented Feb 4, 2020

hstove commented Feb 4, 2020

markmhendrickson commented Feb 11, 2020 •

edited

Loading

		@@ -1,8 +1,10 @@
		import Wallet from '@blockstack/keychain/dist/wallet';
		import Identity from '@blockstack/keychain/dist/identity';

Implement UI for identity #69

Implement UI for identity #69

Conversation

aulneau commented Jan 28, 2020 • edited Loading

What this does

New Components

State

Misc

How to test

kyranjamie Jan 29, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kyranjamie Jan 30, 2020 • edited Loading

Choose a reason for hiding this comment

hstove commented Feb 4, 2020

kyranjamie commented Feb 4, 2020

hstove commented Feb 4, 2020

markmhendrickson commented Feb 11, 2020 • edited Loading

aulneau commented Jan 28, 2020 •

edited

Loading

kyranjamie Jan 29, 2020 •

edited

Loading

kyranjamie Jan 30, 2020 •

edited

Loading

markmhendrickson commented Feb 11, 2020 •

edited

Loading