Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

October updates #156

Merged
merged 8 commits into from
Nov 21, 2023
Merged

October updates #156

merged 8 commits into from
Nov 21, 2023

Conversation

friedger
Copy link
Collaborator

@friedger friedger commented Oct 16, 2023

@vercel
Copy link

vercel bot commented Oct 16, 2023

@friedger is attempting to deploy a commit to the Trust Machines Team on Vercel.

To accomplish this, @friedger needs to request access to the Team.

Afterwards, an owner of the Team is required to accept their membership request.

If you're already a member of the respective Vercel Team, make sure that your Personal Vercel Account is connected to your GitHub account.

@friedger
Copy link
Collaborator Author

This depends on hirosystems/connect#339

@friedger friedger changed the title October updates October updates (WIP) Oct 16, 2023
@markmhendrickson markmhendrickson requested review from kyranjamie and fbwoolf and removed request for kyranjamie and fbwoolf October 16, 2023 14:32
@fbwoolf fbwoolf requested a review from kyranjamie October 16, 2023 15:21
@markmhendrickson
Copy link

@friedger it looks like we can get this one merged now that hirosystems/connect#339 is merged?

@friedger
Copy link
Collaborator Author

@markmhendrickson Yes, I just pushed the commit with the latest version

@markmhendrickson
Copy link

@friedger I'm not sure if I should file as a separate issue or if you want to resolve as part of this PR, but this weekend I was extending my Stacking and found that the modal would throw a validation error (telling me I couldn't stack X number of more cycles) if I'd selected more than 12 minus the total cycles originally selected for the current commitment, instead of throwing the error when selecting more than 12 minus the total cycles *remaining* in current commitment.

Unfortunately I didn't get a good screenshot. Might you want to check the logic here?

@friedger
Copy link
Collaborator Author

@markmhendrickson What is the resolution? Could you clarify instead of throwing the error when selecting more than 12 minus the total cycles *remaining* in current commitment.

@markmhendrickson
Copy link

Relevant scenario:

  • I originally locked for 4 cycles
  • 2 of those cycles have now passed, with 2 remaining
  • I go to extend for 6 more cycles
  • I'm unable to extend for 6 cycles. It errors whenever I put in more than 4 cycles (the original amount I locked) whereas it should error only if I put in more than 10 cycles (the 10 new ones plus the 2 remaining == 12 cycles total, the max permitted)

@markmhendrickson
Copy link

@friedger Let's get this PR released and we can tackle the Stacking bug reported above in the comments separately?

@friedger friedger changed the title October updates (WIP) October updates Nov 16, 2023
@friedger
Copy link
Collaborator Author

I have opened a new issue on connect: hirosystems/connect#342

Copy link

vercel bot commented Nov 17, 2023

An owner of the Trust Machines Team on Vercel accepted @friedger's request to join.

@friedger's commit is now being deployed.

Copy link

vercel bot commented Nov 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
lockstacks ✅ Ready (Inspect) Visit Preview Nov 17, 2023 9:13am

@markmhendrickson
Copy link

@friedger @kyranjamie let's get this shipped and closed out?

@kyranjamie
Copy link
Collaborator

Now you have permissions, if you rebase @friedger do you get a ✅

@friedger
Copy link
Collaborator Author

Ok, I'll do.

@friedger friedger merged commit 11cbcf4 into main Nov 21, 2023
6 of 7 checks passed
@friedger friedger deleted the fix/2023-october-updates branch November 21, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants