Will/deeplink-bridge #208
Will/deeplink-bridge #208
Conversation
Deploying lockstacks with
|
| Latest commit: |
edc0a8e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://5839d3cf.lockstacks.pages.dev |
| Branch Preview URL: | https://will-deeplink-bridge.lockstacks.pages.dev |
|
|
||
| const leatherDetected = window.LeatherProvider !== undefined; | ||
|
|
||
| export const useLeatherSBTCBridgeButton = () => { |
There was a problem hiding this comment.
define as fn, and consider sbtc a word to avoid SBTCB capitalisation
| export const useLeatherSBTCBridgeButton = () => { | |
| export function useLeatherSbtcBridgeButton() { |
| if (!leatherDetected) { | ||
| return; | ||
| } | ||
| (window as any).LeatherProvider?.request('swap', { from: 'STX', to: 'ALEX' }); |
There was a problem hiding this comment.
@kyranjamie FYI the only reason I had to do this any business is because the @leather.io/rpc types don't include this method - is that on purpose? I have also been updating the package as I add these things and plan to push those changes and move our types here over to that.
There was a problem hiding this comment.
@kyranjamie FYI the only reason I had to do this any business is because the @leather.io/rpc types don't include this method - is that on purpose?
Have we included the override of window types anywhere? .request should be there then
There was a problem hiding this comment.
.request is in there but the parameters have types and open is not defined in our request parameters
There was a problem hiding this comment.
Here's what I mean: leather-io/mono#728
|
Case: Leather wallet not installed
Design doesn't have to be on par, we can use the stacks connect/install one and just apply the copy/content (with leather being the only wallet avail to install) |
| @@ -31,8 +31,7 @@ export function ChooseStackingMethodLayout(props: ChooseStackingMethodLayoutProp | |||
| <Messages {...props} /> | |||
| </Box> | |||
| )} | |||
|
|
|||
| {/* <EarnWithSBTCSection {...props} /> */} | |||
| <EarnWithSBTCSection {...props} /> | |||
There was a problem hiding this comment.
| <EarnWithSBTCSection {...props} /> | |
| <EarnWithSbtcSection {...props} /> |
There was a problem hiding this comment.
I think we can only unhide this by monday/official sBTC launch, otherwise this'll already get visible to everybody once merged?
There was a problem hiding this comment.
the domain is currently basically private (not linked anywhere) so i think we're safe to merge soonish - we will have to update marketing links to this page as a part of this release, as well as redirect lockstacks.com -> earn
No description provided.