Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent undefined link to explorer for Bitcoin transaction on submitted screen #4446

Closed
markmhendrickson opened this issue Oct 27, 2023 · 5 comments · Fixed by #4427 or #4488
Closed

Prevent undefined link to explorer for Bitcoin transaction on submitted screen #4446

markmhendrickson opened this issue Oct 27, 2023 · 5 comments · Fixed by #4427 or #4488
Assignees
@pete-watters
Labels
area:bitcoin area:send bug-p2 Critical functionality broken for few users, with no clear workarounds

Comments

@markmhendrickson
Copy link
Collaborator

https://mempool.space/tx/undefined
@markmhendrickson markmhendrickson added bug-p4 Non-critical functionality broken for few users, or there are clear workarounds area:bitcoin area:send labels Oct 27, 2023
@markmhendrickson
Copy link
Collaborator Author

This is a problem on the submission modal even after waiting seconds after broadcast:

Image

Image

@markmhendrickson markmhendrickson added bug-p2 Critical functionality broken for few users, with no clear workarounds and removed bug-p4 Non-critical functionality broken for few users, or there are clear workarounds labels Nov 3, 2023
@markmhendrickson markmhendrickson changed the title Prevent undefined link to explorer for Bitcoin transaction immediately after broadcast Prevent undefined link to explorer for Bitcoin transaction on submitted screen Nov 3, 2023
@pete-watters
Copy link
Contributor

@markmhendrickson what do you want to happen here?

Should I keep the button disabled if the txId is undefined?

@markmhendrickson
Copy link
Collaborator Author

Ideally the button is disabled until the txId is defined, though it seems like in my testing it's never defined even if I wait for awhile on this screen. So, this issue could involve:

  1. Disabling button while loading txID
  2. Fixing issue where txID is never loaded

@pete-watters
Copy link
Contributor

I just tested this as I had to send some funds and I noticed that when you click View Details it does indeed not work, however if you click Copy ID the ID is already available and you can use that to find the transaction in MemPool explorer.

Kapture.2023-11-07.at.09.31.41.mp4

TLDR - I don't think it will be too tricky to fix

@pete-watters pete-watters linked a pull request Nov 7, 2023 that will close this issue
release: alex swaps #4427
Merged
@pete-watters
Copy link
Contributor

This bug was introduced in #4349 as we made some changes in the useExplorerLink to change the name of txid to txId

pete-watters added a commit that referenced this issue Nov 7, 2023
@pete-watters
fix: map txid to txId to match new format of useExplorerLink, closes #…
0578123 
…4446
github-merge-queue bot pushed a commit that referenced this issue Nov 7, 2023
@pete-watters
fix: map txid to txId to match new format of useExplorerLink, closes #…
cbf8814 
…4446
@pete-watters pete-watters linked a pull request Nov 7, 2023 that will close this issue
Prevent undefined link to explorer for Bitcoin transaction on submitted screen #4488
Merged
kyranjamie pushed a commit that referenced this issue Nov 8, 2023
@semantic-release-bot
chore(release): 6.16.0
0db71d6 
## [6.16.0](v6.15.1...v6.16.0) (2023-11-08)

### Features

* change default test acc state ([9d00f06](9d00f06))
* process stacks ledger keys ([7e71b91](7e71b91))

### Bug Fixes

* brc20 send form bug, closes [#4482](#4482) ([a578e08](a578e08))
* **ledger:** stacks contract call signing, closes [#4478](#4478) ([6b81c01](6b81c01))
* map txid to txId to match new format of useExplorerLink, closes [#4446](#4446) ([cbf8814](cbf8814))
* migration redux persist ([bd77be5](bd77be5))
* refactor error label to align icon and make text consistent size, closes [#4166](#4166) ([eb69ae9](eb69ae9))
* sip10 tokens ledger send form, closes [#4491](#4491) ([1bd7837](1bd7837))
* themify yellow, red, green, blue ([642e08a](642e08a))

### Internal

* init ledger store refactor ([19eee1c](19eee1c))
* ledger store ([d3d86cc](d3d86cc))
* post-release merge back ([43750af](43750af))
* post-release merge back ([b9e726e](b9e726e))
* update icon, closes [#4166](#4166) ([b1e934e](b1e934e))
pete-watters added a commit to Nithishvb/extension that referenced this issue Jan 17, 2024
@pete-watters
fix: map txid to txId to match new format of useExplorerLink, closes l…
6219771 
…eather-io#4446
pete-watters pushed a commit to Nithishvb/extension that referenced this issue Jan 17, 2024
@semantic-release-bot @pete-watters
chore(release): 6.16.0
14fa21e 
## [6.16.0](leather-io/extension@v6.15.1...v6.16.0) (2023-11-08)

### Features

* change default test acc state ([9d00f06](leather-io@9d00f06))
* process stacks ledger keys ([7e71b91](leather-io@7e71b91))

### Bug Fixes

* brc20 send form bug, closes [leather-io#4482](leather-io#4482) ([a578e08](leather-io@a578e08))
* **ledger:** stacks contract call signing, closes [leather-io#4478](leather-io#4478) ([6b81c01](leather-io@6b81c01))
* map txid to txId to match new format of useExplorerLink, closes [leather-io#4446](leather-io#4446) ([cbf8814](leather-io@cbf8814))
* migration redux persist ([bd77be5](leather-io@bd77be5))
* refactor error label to align icon and make text consistent size, closes [leather-io#4166](leather-io#4166) ([eb69ae9](leather-io@eb69ae9))
* sip10 tokens ledger send form, closes [leather-io#4491](leather-io#4491) ([1bd7837](leather-io@1bd7837))
* themify yellow, red, green, blue ([642e08a](leather-io@642e08a))

### Internal

* init ledger store refactor ([19eee1c](leather-io@19eee1c))
* ledger store ([d3d86cc](leather-io@d3d86cc))
* post-release merge back ([43750af](leather-io@43750af))
* post-release merge back ([b9e726e](leather-io@b9e726e))
* update icon, closes [leather-io#4166](leather-io#4166) ([b1e934e](leather-io@b1e934e))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pete-watters pete-watters

Labels
area:bitcoin area:send bug-p2 Critical functionality broken for few users, with no clear workarounds
Projects
None yet
Milestone
No milestone
2 participants
@markmhendrickson @pete-watters