Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button nested within button #4550

Closed
kyranjamie opened this issue Nov 21, 2023 · 1 comment · Fixed by #4559
Closed

Button nested within button #4550

kyranjamie opened this issue Nov 21, 2023 · 1 comment · Fixed by #4559
Assignees

Comments

@kyranjamie
Copy link
Collaborator

On home page, I run into

image

cc/ @fbwoolf @pete-watters if related to stacks/ui changes

@pete-watters
Copy link
Contributor

I checked this and we had a nested button on the Ordinal container. I just changed the parent to be a div as it didn't need to be a button

kyranjamie pushed a commit that referenced this issue Nov 28, 2023
## [6.17.0](v6.16.1...v6.17.0) (2023-11-28)

### Features

* extended add-network page with the option to add bitcoin network too ([870574a](870574a))
* support bitcoin ledger, closes [#2893](#2893) ([8a81f58](8a81f58))
* updated dlc-tools package, modified accept bitcoin contract rpc params ([0742719](0742719))

### Bug Fixes

* account circle numbers and delete unused code ([a6588dc](a6588dc))
* add background state for ledger connect modal ([41fef37](41fef37))
* align heading text left, closes [#4423](#4423) ([31ddc89](31ddc89))
* allow users to click input when populated, closes [#4582](#4582) ([222a854](222a854))
* axios get request for config ([3ad4b06](3ad4b06))
* bitcoin fees tx size calc ([3f5718c](3f5718c))
* filter network dust amounts when sending all ([b7a34a9](b7a34a9))
* fixed previously saved network loading ([c8724b4](c8724b4))
* give more margin to Continue button in extension mode, closes [#4423](#4423) ([8d61e93](8d61e93))
* mark ui bugs ([e9da651](e9da651))
* minor ui bugs ([0095ebc](0095ebc))
* **popup:** avatar circle on stacks transactions ([8dbfefe](8dbfefe))
* provider name in tests ([6b75267](6b75267))
* psbt bare utxo signing ([954e707](954e707))
* qr code ([b035f20](b035f20))
* remove not working onFocusborder, to be fixed in [#4583](#4583) ([cddf09b](cddf09b))
* sign out and close all tabs on create wallet, closes [#4517](#4517) ([0b47dea](0b47dea))
* skip bitcoin contract tests ([83c4d04](83c4d04))

### Internal

* fix type errors ([98f5ddf](98f5ddf))
* icon tokens ([91403d7](91403d7))
* migrate icons ([fbc6580](fbc6580))
* post-release merge back ([c3c7bd1](c3c7bd1))
* remove bitcoinjs-lib from inscription send ([97854b0](97854b0))
* remove patch file ([be8b040](be8b040))
* remove remaining old icon libraries ([1fa4e6c](1fa4e6c))
* remove stacks ui ([99fb117](99fb117))
* remove unneeded parent button, closes [#4550](#4550) ([c44a7bb](c44a7bb))
* update font and color for receive asset ([800fa3e](800fa3e))
* update panda ([2807b50](2807b50))
* update readme ([c86f2ab](c86f2ab))
* use tokens for border radius ([b387903](b387903))
pete-watters added a commit to Nithishvb/extension that referenced this issue Jan 17, 2024
pete-watters pushed a commit to Nithishvb/extension that referenced this issue Jan 17, 2024
## [6.17.0](leather-io/extension@v6.16.1...v6.17.0) (2023-11-28)

### Features

* extended add-network page with the option to add bitcoin network too ([870574a](leather-io@870574a))
* support bitcoin ledger, closes [leather-io#2893](leather-io#2893) ([8a81f58](leather-io@8a81f58))
* updated dlc-tools package, modified accept bitcoin contract rpc params ([0742719](leather-io@0742719))

### Bug Fixes

* account circle numbers and delete unused code ([a6588dc](leather-io@a6588dc))
* add background state for ledger connect modal ([41fef37](leather-io@41fef37))
* align heading text left, closes [leather-io#4423](leather-io#4423) ([31ddc89](leather-io@31ddc89))
* allow users to click input when populated, closes [leather-io#4582](leather-io#4582) ([222a854](leather-io@222a854))
* axios get request for config ([3ad4b06](leather-io@3ad4b06))
* bitcoin fees tx size calc ([3f5718c](leather-io@3f5718c))
* filter network dust amounts when sending all ([b7a34a9](leather-io@b7a34a9))
* fixed previously saved network loading ([c8724b4](leather-io@c8724b4))
* give more margin to Continue button in extension mode, closes [leather-io#4423](leather-io#4423) ([8d61e93](leather-io@8d61e93))
* mark ui bugs ([e9da651](leather-io@e9da651))
* minor ui bugs ([0095ebc](leather-io@0095ebc))
* **popup:** avatar circle on stacks transactions ([8dbfefe](leather-io@8dbfefe))
* provider name in tests ([6b75267](leather-io@6b75267))
* psbt bare utxo signing ([954e707](leather-io@954e707))
* qr code ([b035f20](leather-io@b035f20))
* remove not working onFocusborder, to be fixed in [leather-io#4583](leather-io#4583) ([cddf09b](leather-io@cddf09b))
* sign out and close all tabs on create wallet, closes [leather-io#4517](leather-io#4517) ([0b47dea](leather-io@0b47dea))
* skip bitcoin contract tests ([83c4d04](leather-io@83c4d04))

### Internal

* fix type errors ([98f5ddf](leather-io@98f5ddf))
* icon tokens ([91403d7](leather-io@91403d7))
* migrate icons ([fbc6580](leather-io@fbc6580))
* post-release merge back ([c3c7bd1](leather-io@c3c7bd1))
* remove bitcoinjs-lib from inscription send ([97854b0](leather-io@97854b0))
* remove patch file ([be8b040](leather-io@be8b040))
* remove remaining old icon libraries ([1fa4e6c](leather-io@1fa4e6c))
* remove stacks ui ([99fb117](leather-io@99fb117))
* remove unneeded parent button, closes [leather-io#4550](leather-io#4550) ([c44a7bb](leather-io@c44a7bb))
* update font and color for receive asset ([800fa3e](leather-io@800fa3e))
* update panda ([2807b50](leather-io@2807b50))
* update readme ([c86f2ab](leather-io@c86f2ab))
* use tokens for border radius ([b387903](leather-io@b387903))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants